-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up styles for older browsers #236
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for popover-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@stacyk I've removed the references here to layers (and most nesting). There's something happening that's causing a lot of the layout styles to not be applied. Testing on FF 95, custom properties are valid but not all of them are reflected in the styles of the page. Can you see the same thing in Safari 15? |
@stacyk I figured out why the size variables were not working. It's due to the |
@dvdherron I have Safari 18 and there isn't a way to downgrade that I know of, so using Saucelabs is the way to go for that. Sounds like you are on the right trail so let me know if you want a review when ready. |
@jgerigmeyer @stacyk I think this is ready for review. I removed the references to layers (except for the demo example). I changed the example from having a red background to having a red border. With the former, an old browser could not read the text (It was white text on a white background). I also removed nesting and added some If you test this page on Safari 16, it seems to only work when you choose The shadowed popovers in older browsers don't seem to be getting the "UA Stylesheet" styles we are injecting with JS. I think that's because we are using |
* main: typo pin back ts for now chore(deps-dev): Bump the npm-minor-upgrades group with 9 updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
The shadowed popovers in older browsers don't seem to be getting the "UA Stylesheet" styles we are injecting with JS. I think that's because we are using
.innerHTML
to create those elements @jgerigmeyer? These popovers aren't positioned so they push content around when they are opened.
Yeah, I think this is directly related to this note. I think I fixed it (conditionally re-injecting the styles in shadow roots) in 0f301bc -- take a look and see what you think?
Related Issue(s)
Fixes #205
Steps to test/reproduce
@layers
popover example).Please explain how to best reproduce the issue and/or test the changes locally (including the pages/URLs/views/states to review).