-
-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
7c9fd67
commit 5e4541a
Showing
2 changed files
with
24 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5e4541a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This includes enough breaking changes that I think a minor version bump isn't really appropriate. Should probably be
1.0.0-alpha.1
or something.5e4541a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always assume the rules are different before 1.0 - you just can't bump versions semantically without going to 1 when you're likely to make breaking changes with every release.
5e4541a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Jonny. From what I understand with semantic versioning 1.0 does not mean "it's ready!" (when is it ever ready? "1.0" always feels arbitrary to me) but "we just broke things the first time".
5e4541a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mirisuzanne I understand what you're saying, but don't see how that works well in practice. We're using a number of packages <1.0, but I wouldn't expect a minor or patch version to include breaking changes.
5e4541a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. I understood it differently. You can pull that version and re-release if you think it's a problem.