Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu snap for drive #881

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Ubuntu snap for drive #881

wants to merge 21 commits into from

Conversation

Dedsec1
Copy link

@Dedsec1 Dedsec1 commented Feb 12, 2017

Hi odeke-em

i wanted to make it easier for people to install drive on different types of Linux distros, so i went ahead an setup an Ubuntu snap for drive, you can install drive by doing the following command. luckily snaps can be deployed on other distros as well such as Redhat, CentOS, Debian etc. currently i have my launchpad account pulling from my fork automatically using git and building an new snap each time i change something. so once you add my snapcraft.yaml file to the main repo for drive, i can change my launchpad settings to grab any changes automatically and push an new snap.

https://github.com/Dedsec1/drive/

https://github.com/Dedsec1/drive/blob/master/snapcraft.yaml

sudo snap install drive --classic

Regards

Dedsec1

@@ -0,0 +1,20 @@
name: drive
summary: Google Drive client for the commandline
version: current

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!
Great work!
Just a suggestion. The version field should be a string, so you should put it in quotes.
Also, if you're tracking the master branch in github, it might be better to set:
version: 'master'
What do you think?

@idvoretskyi
Copy link

@odeke-em is there anything that blocks this PR from merging?

@odeke-em
Copy link
Owner

My apologies for the very late reply @Dedsec1, I have been swamped for the past year and more.
Awesome, I'll kindly page some Linux folks to help me review this change @shaggytwodope @m-svo.
Also @LyzardKing posted some feedback PTAL.

@idvoretskyi nothing blocking it, I was just away from here for a while :)

@LyzardKing
Copy link

LyzardKing commented Jun 20, 2019

@odeke-em The only thing I'd add to the current PR are the following lines:

version: 'master'
version-script: |
    grep "Version =" src/about.go | cut -d'"' -f2
base: core18

First we set the version to a string, then we override it with the actual drive version.
Then in the 3rd line the base is updated to the latest ubuntu LTS

Also, the classic option when installing is no longer needed.
@odeke-em If there's anything needed to get this completed let me know!

@omicron-b
Copy link

@odeke-em sorry, not my area of expertise, so not able to review

@LyzardKing
Copy link

@odeke-em There seems to be an outdated version already uploaded to the snap store.
Once the snapcraft.yaml file is included in the repo you can ask on the snapcraft forum for the ownership of the snap to be transferred to you. And the snap would build automatically on every upstream commit.

@idvoretskyi
Copy link

the ownership of the snap to be transferred to you

+1.

@LyzardKing
Copy link

@odeke-em What can we do to get this merged? I can open another PR with my changes..
A part from that I can tell that I have it built with my snap changes and it seems to work properly. Although there might be something else that needs testing..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants