-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu snap for drive #881
base: master
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,20 @@ | |||
name: drive | |||
summary: Google Drive client for the commandline | |||
version: current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
Great work!
Just a suggestion. The version field should be a string, so you should put it in quotes.
Also, if you're tracking the master branch in github, it might be better to set:
version: 'master'
What do you think?
@odeke-em is there anything that blocks this PR from merging? |
My apologies for the very late reply @Dedsec1, I have been swamped for the past year and more. @idvoretskyi nothing blocking it, I was just away from here for a while :) |
@odeke-em The only thing I'd add to the current PR are the following lines:
First we set the version to a string, then we override it with the actual drive version. Also, the classic option when installing is no longer needed. |
@odeke-em sorry, not my area of expertise, so not able to review |
@odeke-em There seems to be an outdated version already uploaded to the snap store. |
+1. |
@odeke-em What can we do to get this merged? I can open another PR with my changes.. |
Hi odeke-em
i wanted to make it easier for people to install drive on different types of Linux distros, so i went ahead an setup an Ubuntu snap for drive, you can install drive by doing the following command. luckily snaps can be deployed on other distros as well such as Redhat, CentOS, Debian etc. currently i have my launchpad account pulling from my fork automatically using git and building an new snap each time i change something. so once you add my snapcraft.yaml file to the main repo for drive, i can change my launchpad settings to grab any changes automatically and push an new snap.
https://github.com/Dedsec1/drive/
https://github.com/Dedsec1/drive/blob/master/snapcraft.yaml
sudo snap install drive --classic
Regards
Dedsec1