-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Make conda builds for all platforms and Python versions #17
base: master
Are you sure you want to change the base?
Conversation
- pytest | ||
|
||
about: | ||
home: https://github.com/odlgroup/odl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not updated obviously
- cudatoolkit | ||
- boost | ||
# Make sure to run "conda config --append channels odlgroup" | ||
- odl >=0.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.4.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to keep the version perfectly in sync, so probably a version after the split is sufficient. It will anyway pick the most recent one.
Very good initiative, I'll try to get windows settled. |
BOOST_LIBRARY=$PREFIX/lib/libboost_python.so | ||
|
||
ODLCUDA_BUILDDIR=$SRC_DIR/build-py$PYTHON_VERSION | ||
ODLCUDA_NUMPY_BUILDOPTS="-DPYTHON_NUMPY_INCLUDE_DIR=$PREFIX/lib/python$PYTHON_VERSION/site-packages/numpy/core/include" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use
$ python -c "import numpy; print(numpy.get_include())"
Now everything works as expected with conda's version of boost and CUDA-toolkit. That should also make it easier to get the Windows build working since the paths are more predictable. I've uploaded the last build to Anaconda cloud, users can smoothly install from there. |
I'll see if i can get this working on windows as well |
Would be great! I can summarize some of my experiences:
|
Proposal: Go ahead with Linux, I'll catch up with windows "sometime". |
When installing on a new machine using |
I added the
meta.yaml
file and abuild.sh
build script for Linux and Mac. For windows builds, we need abld.bat
file like this one, just with proper build instructions.What's currently known to work:
Linux:
EDIT: I took the package built on my office computer and installed it on my laptop, where CUDA is located in a different directory. Works nicely.
Mac:
Windows:
Instruction on how to build a conda package are here.
Especially environment variables that can be used during build are listed here.
EDIT: Forgot to mention that the build expects the environment variables
CUDA_ROOT
andCUDA_COMPUTE
to be defined. In Linux, you would runCUDA_ROOT=/opt/cuda CUDA_COMPUTE=30 conda build .
in the
conda
directory.