[IMP] pivot: display pivot name in auto complete dropdown

Unless the auto complete suggestion is selected, it only shows the id
of the pivot and not the name. This commit changes that to always show
the name of the pivot in addition to its id.

closes #5270

Task: 3953742
Signed-off-by: Pierre Rousseau (pro) <[email protected]>

src/components/composer/autocomplete_dropdown/autocomplete_dropdown.xml

@@ -24,7 +24,7 @@
           <div
             class="o-autocomplete-description text-truncate"
             t-esc="proposal.description"
-            t-if="props.selectedIndex === proposal_index"
+            t-if="props.selectedIndex === proposal_index || proposal.alwaysExpanded"
           />
         </div>
       </t>

src/registries/auto_completes/auto_complete_registry.ts

@@ -17,6 +17,7 @@ export interface AutoCompleteProposal {
    * Key to use for fuzzy search.
    */
   fuzzySearchKey?: string;
+  alwaysExpanded?: boolean;
 }
 
 export interface AutoCompleteProvider {

src/registries/auto_completes/pivot_auto_complete.ts

@@ -41,6 +41,7 @@ autoCompleteProviders.add("pivot_ids", {
           description: definition.name,
           htmlContent: [{ value: str, color: tokenColors.NUMBER }],
           fuzzySearchKey: str + definition.name,
+          alwaysExpanded: true,
         };
       })
       .filter(isDefined);

tests/composer/auto_complete/pivot_auto_complete_store.test.ts

@@ -34,12 +34,14 @@ describe("spreadsheet pivot auto complete", () => {
           fuzzySearchKey: "1My pivot",
           htmlContent: [{ color: "#02c39a", value: "1" }],
           text: "1",
+          alwaysExpanded: true,
         },
         {
           description: "My pivot 2",
           fuzzySearchKey: "2My pivot 2",
           htmlContent: [{ color: "#02c39a", value: "2" }],
           text: "2",
+          alwaysExpanded: true,
         },
       ]);
       autoComplete?.selectProposal(autoComplete?.proposals[0].text);

tests/composer/autocomplete_dropdown_component.test.ts

@@ -354,6 +354,25 @@ describe("Functions autocomplete", () => {
       await keyDown({ key: "Enter" });
       expect(composerStore.currentContent).toBe("=SUM(");
     });
+
+    test("autocomplete proposal can be automatically expanded", async () => {
+      registries.autoCompleteProviders.add("test", {
+        getProposals() {
+          return [
+            { text: "option 1", description: " descr1", alwaysExpanded: true },
+            { text: "option 2", description: " descr1", alwaysExpanded: true },
+            { text: "option 3", description: " descr1", alwaysExpanded: false },
+          ];
+        },
+        selectProposal() {},
+      });
+      registerCleanup(() => registries.autoCompleteProviders.remove("test"));
+      await typeInComposer("=SUM(");
+      const proposals = [...fixture.querySelectorAll(".o-autocomplete-value")].map(
+        (el) => el.parentElement?.textContent
+      );
+      expect(proposals).toEqual(["option 1 descr1", "option 2 descr1", "option 3"]);
+    });
   });
 
   describe("autocomplete functions SUM IF", () => {