[FIX] cells: faster getter to get cell

getCellById self-time was ~13.6% and is now ~9.1% (average over 5 runs) opw-3588401 closes #3189 Task: 3588401 X-original-commit: 0d9bf0c Signed-off-by: Rémi Rahir (rar) <[email protected]> Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
odoo · Nov 17, 2023 · f01711b · f01711b
1 parent 95569a7
commit f01711b
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/src/plugins/core/cell.ts b/src/plugins/core/cell.ts
@@ -275,14 +275,9 @@ export class CellPlugin extends CorePlugin<CoreState> implements CoreState {
    */
   getCellById(cellId: UID): Cell | undefined {
     // this must be as fast as possible
-    for (const sheetId in this.cells) {
-      const sheet = this.cells[sheetId];
-      const cell = sheet[cellId];
-      if (cell) {
-        return cell;
-      }
-    }
-    return undefined;
+    const position = this.getters.getCellPosition(cellId);
+    const sheet = this.cells[position.sheetId];
+    return sheet[cellId];
   }
 
   /*