-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docs of demandlib #44
Conversation
This reverts commit c9284c6.
I will not add the usage, because the usage chapter will be created in PR #45. We should merge this first, if its fine for you. I changed the structure of the docs a bit but mainly added content. Nothing fundamental. Proofing would be good, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The verbosity is very adequate and I don't see any mistakes. Thanks. (Still, you might consider adding a sentence about the limitations of the profiles.)
|
||
\theta_0 &= 40^\circ C | ||
|
||
Types of houses: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understand, the profiles include space heating (SH) and domestic hot water (DHW). Thus, they become inaccurate if the insulation is different from the one originally assumed: Demand in summer is dominated by DHW, demand in summer may or may not be dominated by SH - depending on the insulation. (This is also the way, I interpret #20.)
Maybe, this limitation should be made explicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just revised the general structure and added some information about electrical load profiles. I did not touch the content of the heat profiles.
I added an issue for further ToDo's #48. |
[ ] usageDocs can be found here.