Fix/setup #187
Merged
Fix/setup #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travis.ci is no longer used as a service
I also deleted files that had no content and were not included in the docs.
Taken from oemof-solph commit 0b03a258fd6973ccd36bde9b4d1be285b87d81e7.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
examples/absorption_heatpump_and_chiller/cooling_cap_dependence_on_cooling_water_temp.py
Fixed
Show fixed
Hide fixed
examples/absorption_heatpump_and_chiller/cooling_cap_dependence_on_cooling_water_temp.py
Fixed
Show fixed
Hide fixed
examples/absorption_heatpump_and_chiller/cooling_cap_dependence_on_cooling_water_temp.py
Fixed
Show fixed
Hide fixed
examples/compression_heatpump_and_chiller/airsource_heatpump_const_max_output.py
Fixed
Show fixed
Hide fixed
examples/stratified_thermal_storage/investment_fixed_ratio_generic_storage.py
Fixed
Show fixed
Hide fixed
examples/stratified_thermal_storage/investment_independent_generic_storage.py
Fixed
Show fixed
Hide fixed
Flake8 also checks comments, but Black does not enforce this. I would allow long comments for now.
examples/compression_heatpump_and_chiller/airsource_heatpump_variable_max_output.py
Fixed
Show fixed
Hide fixed
examples/stratified_thermal_storage/investment_independent_generic_storage.py
Fixed
Show fixed
Hide fixed
This works around the problem that labels might be set inconsistently because of multi-inheritence.
The CSP facade needs poa_horizontal_ratio, which is no longer available in more recent versions of pvlib.
This is because Pyomo has no reproducible line order.
fwitte
reviewed
Oct 11, 2024
examples/compression_heatpump_and_chiller/airsource_heatpump_const_max_output.py
Outdated
Show resolved
Hide resolved
fwitte
reviewed
Oct 11, 2024
examples/compression_heatpump_and_chiller/airsource_heatpump_variable_max_output.py
Outdated
Show resolved
Hide resolved
Following the renaming in solph.
fwitte
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates oemof.thermal to current package standards, in the sense of making it compatible to current versions
Known issues: An old version of pvlib is needed to calculate solar radiation.