Skip to content

Commit

Permalink
rdma/fi_domain: Add page size MR attr field
Browse files Browse the repository at this point in the history
Page size allows applications to optionally notify the provider the page
size to be used for an MR allocation. Typically, providers can select
the optimal page size. In cases where a VA range has zero pages backing
it, the provider may not know the optimal page size during registration.
Rather than always use a less efficient page size, allow apps to specify
the page size to be used. If page size is zero, provider will select the
page size.

If non-zero, page size must be page size support by OS. If a specific
page size is specified for a memory region during creation, all pages
later associated with the region must be of the given size. Attaching a
memory page of a different size to a region may result in failed
transfers to or from the region.

Signed-off-by: Ian Ziemba <[email protected]>
  • Loading branch information
iziemba authored and j-xiong committed Jun 14, 2024
1 parent 45e8d14 commit 03a2ea2
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 0 deletions.
1 change: 1 addition & 0 deletions include/rdma/fi_domain.h
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ struct fi_mr_attr {
int synapseai;
} device;
void *hmem_data;
size_t page_size;
};

struct fi_mr_modify {
Expand Down
21 changes: 21 additions & 0 deletions man/fi_mr.3.md
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,7 @@ struct fi_mr_attr {
int synapseai;
} device;
void *hmem_data;
size_t page_size;
};
struct fi_mr_auth_key {
Expand Down Expand Up @@ -788,6 +789,26 @@ field is determined by the value specified through iface.
## hmem_data
The hmem_data field is reserved for future use and must be null.

## page_size
Page size allows applications to optionally provide a hint at what the
optimal page size is for the an MR allocation. Typically, providers can
select the optimal page size. In cases where VA range has zero pages
backing it, which is supported with FI_MR_ALLOCATED unset, the provider
may not know the optimal page size during registration. Rather than use
a less efficient page size, this attribute allows applications to specify
the page size to be used.

If page size is zero, provider will select the page size.

If non-zero, page size must be supported by OS. If a specific page size
is specified for a memory region during creation, all pages later
associated with the region must be of the given size. Attaching a memory
page of a different size to a region may result in failed transfers to
or from the region.

Providers may choose to ignore page size. This will result in a provider
selected page size always being used.

## fi_hmem_ze_device

Returns an hmem device identifier for a level zero <driver, device> tuple.
Expand Down
5 changes: 5 additions & 0 deletions prov/util/src/util_mr_map.c
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,11 @@ void ofi_mr_update_attr(uint32_t user_version, uint64_t caps,
cur_abi_attr->device.reserved = 0;
cur_abi_attr->hmem_data = NULL;
}

if (FI_VERSION_GE(user_version, FI_VERSION(1, 22)))
cur_abi_attr->page_size = user_attr->page_size;
else
cur_abi_attr->page_size = 0;
}

int ofi_mr_regattr(struct fid *fid, const struct fi_mr_attr *attr,
Expand Down

0 comments on commit 03a2ea2

Please sign in to comment.