Skip to content

Commit

Permalink
fabtests/pytest: account for process startup overhead in client-serve…
Browse files Browse the repository at this point in the history
…r tests

Client-server tests launch tests over SSH which can introduce delays in
addition to the specified timeout. This change adds more time before timing out

Signed-off-by: Wenduo Wang <[email protected]>
  • Loading branch information
wenduwan authored and shijin-aws committed Jun 10, 2024
1 parent ff87df2 commit 7b36891
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fabtests/pytest/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ def _run_client_command(self, server_process, client_command, output_filename=No
shell=True,
universal_newlines=True,
),
self._timeout,
self._timeout + SERVER_RESTART_DELAY_MS/1000,
output_file,
)

Expand Down Expand Up @@ -554,7 +554,7 @@ def run(self):
server_timed_out = False
try:
server_output, _ = server_process.communicate(
timeout=self._timeout)
timeout=self._timeout + SERVER_RESTART_DELAY_MS/1000)
except TimeoutExpired:
server_process.terminate()
server_timed_out = True
Expand Down

0 comments on commit 7b36891

Please sign in to comment.