prov/efa: Handle receive window overflow #10194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jiaxiyan it's the convention to have change and unit test in the same commit |
shijin-aws
reviewed
Jul 22, 2024
| } | ||
|
|
||
| overflow_pke_list_entry->pkt_entry = pkt_entry; | ||
| dlist_insert_head(&overflow_pke_list_entry->entry, &peer->overflow_pke_list); |
There was a problem hiding this comment.
Is there any preference on insert head or tail here?
There was a problem hiding this comment.
No preference since we do not care about the ordering of this linked list.
| /* Message id that overflows the receive window should be put in the | ||
| * overflow_pke_list and return 1 */ | ||
| test_efa_rdm_peer_reorder_msg_impl(resource, exp_msg_id, msg_id, expected_ret); | ||
| } |
There was a problem hiding this comment.
Can we have more unit tests to cover
- moving entry from overflow to recv window
- two pkt entries of same msg id will be appended to the same entry.
shijin-aws
reviewed
Jul 23, 2024
jiaxiyan
force-pushed
the
recvwin
branch
2 times, most recently
from
4ee0395 to
4b024e7
Compare
shijin-aws
reviewed
Jul 25, 2024
|
|
||
| pkt_entry1 = *ofi_recvwin_get_msg((&peer->robuf), 17000); | ||
| assert_non_null(pkt_entry1); | ||
| assert_non_null(pkt_entry1->next); |
There was a problem hiding this comment.
better to have an assert that pkt_entry1->next == pkt_entry2
jiaxiyan
force-pushed
the
recvwin
branch
2 times, most recently
from
b550d95 to
74d45dc
Compare
Store out-of-order packet entries that overflow the receive window in a double linked list. After processing a window size of packet entries, move the packet entries in the linked list back to the receive window if they can fit in the window now. Signed-off-by: Jessie Yang <[email protected]>
shijin-aws
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When receiving an out-of-order message that exceeds the current receive window, instead of a hard fail, store this packet entry in a double linked list. After finishing processing a window size multiple of packet entries, iterate through the linked list.
Put the packet entry back to the circular queue if it can fit within the receive window now, and remove it from the linked list. If using the multi-req protocol and a packet entry with the same msg_id already exists in the receive window, append this packet entry to the existing packet entry.