prov/efa: introduce FI_EFA_IFACE to restrict visible NICs #10210
Conversation
|
Could it be named FI_EFA_IFACE to be consistent with other providers? |
Could you share a link to the implementation of other providers? |
|
@shijin-aws See these man pages about FI_TCP_IFACE and FI_VERBS_IFACE: |
wenduwan
changed the title
|
@j-xiong Thank you! PR is updated accordingly. |
|
@zachdworkin I imagine the intel CI failure is unrelated, correct? |
It is unrelated. The opt-out path should have been taken since all of the changes in this PR are under prov/efa. If you want Intel-CI to opt-out in the future please rebase so that only the changes in your PR are the ones in the changeset in the comparison between the base branch you are pull requesting against and your changes. |
|
Should we advertise this env in man page? |
|
Yes, I think so. |
This patch introduces an environment variable to limit NICs that are visible to the application via fi_getinfo. FI_EFA_IFACE accepts the following values: - all(default): All NICs are visible to the application - dev0[,dev1,...]: Only devices whose name exactly matches one of the provided values are visible to the application. Signed-off-by: Wenduo Wang <[email protected]>
Good point. Added documentation. |
| if ((match > efa_env.iface && *(match - 1) != ',') || | ||
| ((match + strlen(name)) < end && *(match + strlen(name)) != ',')) { | ||
| /* Skip partial match */ | ||
| match += strlen(name); |
There was a problem hiding this comment.
Clarified with @wenduwan offline. But this logic is not intuitive to new readers.
|
bot:aws:retest |
This patch introduces an environment variable to limit which NICs are visible to the application via fi_getinfo.