prov/shm: add more error output #9344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the shm provider fails to configure, there is no helpful output to let the user know what check failed. This adds some helpful messages. Signed-off-by: Alexia Ingerson <[email protected]>
shefty
reviewed
Sep 16, 2023
prov/shm/configure.m4
Outdated
| [AC_MSG_ERROR([shm provider requested, but no CMA support found])]) | ||
| AS_IF([test $atomics_happy -eq 0], | ||
| [AC_MSG_ERROR([shm provider requested, but no atomics support found])]) | ||
| ]) |
There was a problem hiding this comment.
Could we drop the outer AS_IF() and just report something like "shm provider disabled: shm_open not found", etc.?
Even if enable-shm wasn't set, the reason for it being disabled is clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the shm provider fails to configure, there is no helpful output to let the user know what check failed. This adds some helpful messages.