-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1.15.x] util/memhooks: Fix a bug when calculating mprotect region #9559
Conversation
@shijin-aws Could you rebase this one to pick up CI changes in the v1.15.x branch? ubuntu 18.04 and macos 10.5 runners don't seem to be working any more. |
0c0fad4
to
b124503
Compare
macos check failed
Doesn't relate to this change though |
@shijin-aws That's right. Some CPU affinity setting related definitions are missing for osx fabtests build. It's also weird that the compiler would replace the struct member |
I would ignore the macos build result for this PR. |
Same segfaults as v1.17.x backport, will look into |
In ofi_write_patch, the bound should be the page end for the end of the address + data_size. And since it's the end of the page, when calculating the length, it needs to add 1 to make the length a multiple of page size. Signed-off-by: Shi Jin <[email protected]> (cherry picked from commit faf4ff4)
b124503
to
6d1404f
Compare
bot:aws:retest |
backport #9552