[v1.19.x] configure.ac Fix --with-lttng causing yes/ to populate {CPP,LD}FLAGS
#9566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When configured with LTTng-UST support without specifying an installation prefix (--with-lttng), the resulting CPPFLAGS and LDFLAGS contain the (likely) non-existant `yes/` path. This is a little hacky since it technically breaks builds for people who use `yes/` for some reason, but seems to be the convention used elsewhere. Signed-off-by: Darryl Abbate <[email protected]> (cherry picked from commit bbcbaf2) NOTE: This commit is cherry-picked from main to make CI build check work properly. Without this one, the '--with-lttng' configure option used by CI would lead to failure with the following error message: checking if libibverbs is linkable by libtool... no ...... configure: verbs provider: disabled configure: WARNING: verbs provider was requested, but cannot be compiled configure: error: Cannot continue Commented-by: Jianxin Xiong <[email protected]>
j-xiong
changed the title
--with-lttng causing yes/ to populate {CPP,LD}FLAGS--with-lttng causing yes/ to populate {CPP,LD}FLAGS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configured with LTTng-UST support without specifying an installation prefix (--with-lttng), the resulting CPPFLAGS and LDFLAGS contain the (likely) non-existant
yes/path.This is a little hacky since it technically breaks builds for people who use
yes/for some reason, but seems to be the convention used elsewhere.Signed-off-by: Darryl Abbate [email protected]
(cherry picked from commit bbcbaf2)
NOTE:
This commit is cherry-picked from main to make CI build check work properly. Without this one, the '--with-lttng' configure option used by CI would lead to failure with the following error message:
Commented-by: Jianxin Xiong [email protected]