[v1.18.x] Cherry-picked fixes to allow CI build check to pass #9570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When configured with LTTng-UST support without specifying an installation prefix (--with-lttng), the resulting CPPFLAGS and LDFLAGS contain the (likely) non-existant `yes/` path. This is a little hacky since it technically breaks builds for people who use `yes/` for some reason, but seems to be the convention used elsewhere. Signed-off-by: Darryl Abbate <[email protected]> (cherry picked from commit bbcbaf2) NOTE: This commit is cherry-picked from main to make CI build check work properly. Without this one, the '--with-lttng' configure option used by CI would lead to failure with the following error message: checking if libibverbs is linkable by libtool... no ...... configure: verbs provider: disabled configure: WARNING: verbs provider was requested, but cannot be compiled configure: error: Cannot continue Commented-by: Jianxin Xiong <[email protected]>
These are necessary to compile on MacOS. Signed-off-by: Ken Raffenetti <[email protected]> (cherry picked from commit c0191d2)
This causes a compile error on MacOS with clang 14.0.0 because memset is
substituted as a builtin function by the preprocessor.
common/hmem.c:172:25: error: no member named '__builtin___memset_chk' in 'struct ft_hmem_ops'
return hmem_ops[iface].memset(device, buf, value, size);
~~~~~~~~~~~~~~~ ^
Signed-off-by: Ken Raffenetti <[email protected]>
(cherry picked from commit dd2ce59)
sched_setaffinity is only available on Linux. Signed-off-by: Ken Raffenetti <[email protected]> (cherry picked from commit 3425fa7)
Signed-off-by: Ken Raffenetti <[email protected]> (cherry picked from commit 9ad3a20)
|
no pudding cups :( |
|
@shefty I heard you. The last update should do the trick. |
…r_comp Introduce a separate function ft_read_cq to do the cq read part in ft_get_cq_comp, Also introduce tag as an input parameter for ft_read_cq and its child functions. It is aimed to avoid setting the global ft_tag which could be messy. Signed-off-by: Shi Jin <[email protected]> (cherry picked from commit 2419731)
The current rdm_tagged_peek test uses sread which is not available for some provider like efa. This patch makes this test more general to support all available comp_method, including sread and the default non-wait read. It also makes the do_send retry fi_tsend when it hits EAGAIN. Signed-off-by: Shi Jin <[email protected]> (cherry picked from commit 61fa45d)
It was possible for the client to complete the finalize send before the server gets the last 0xabc completion, causing a tag mismatch when processing the incorrect receive. This removes the extra synchronization sends and adds an OOB sync to make sure all of the test sends have finished before quitting the test. Signed-off-by: Alexia Ingerson <[email protected]> (cherry picked from commit 09ca779)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) Fix MacOS build issues
(2) Fix build issue with '--with-lttng' configure option
(3) Fix fi_rdm_tagged_peek test that would fail the ucx provider