Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fabtests/benchmarks: Add rma_pingpong benchmark #9613

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

rauteric
Copy link
Contributor

RMA latency test for write and writedata operations.

  • Write: polls receive buffer on receive side
  • Writedata: polls for completions on receiver side

@rauteric rauteric force-pushed the fabtests_rma_pingpong_squashed branch from 9d613d9 to dee828e Compare November 27, 2023 20:28
@shijin-aws shijin-aws requested review from j-xiong and a team November 27, 2023 20:29
@rauteric rauteric changed the title Add rma_pingpong benchmark fabtests/examples: Add rma_pingpong benchmark Nov 27, 2023
@rauteric rauteric changed the title fabtests/examples: Add rma_pingpong benchmark fabtests/benchmarks: Add rma_pingpong benchmark Nov 27, 2023
@shijin-aws
Copy link
Contributor

bot:aws:retest

@rauteric rauteric force-pushed the fabtests_rma_pingpong_squashed branch from dee828e to d0a563e Compare November 27, 2023 23:51
fabtests/benchmarks/benchmark_shared.c Outdated Show resolved Hide resolved
fabtests/common/shared.c Show resolved Hide resolved
fabtests/common/shared.c Outdated Show resolved Hide resolved
fabtests/common/shared.c Outdated Show resolved Hide resolved
fabtests/common/shared.c Outdated Show resolved Hide resolved
fabtests/common/shared.c Outdated Show resolved Hide resolved
fabtests/common/shared.c Outdated Show resolved Hide resolved
fabtests/common/shared.c Outdated Show resolved Hide resolved
fabtests/include/shared.h Outdated Show resolved Hide resolved
fabtests/include/shared.h Outdated Show resolved Hide resolved
@shijin-aws
Copy link
Contributor

bot:aws:retest

@rauteric rauteric force-pushed the fabtests_rma_pingpong_squashed branch 2 times, most recently from aad76a1 to 01df27a Compare December 4, 2023 19:27
@rauteric
Copy link
Contributor Author

rauteric commented Dec 4, 2023

Thanks @j-xiong and @shijin-aws, resolved all comments except for the question about rx_seq above.

@shijin-aws
Copy link
Contributor

bot:aws:retest

Copy link
Contributor

@shijin-aws shijin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: add fabtests/benchmarks prefix in your commit's title

@rauteric rauteric force-pushed the fabtests_rma_pingpong_squashed branch from 01df27a to 27bf388 Compare December 4, 2023 19:44
Copy link
Contributor

@aingerson aingerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a glance and had some nitpicky things. Nice test though. Thanks!

fabtests/Makefile.am Show resolved Hide resolved
fabtests/benchmarks/benchmark_shared.c Outdated Show resolved Hide resolved
fabtests/benchmarks/benchmark_shared.c Show resolved Hide resolved
fabtests/benchmarks/benchmark_shared.c Outdated Show resolved Hide resolved
fabtests/benchmarks/rma_pingpong.c Outdated Show resolved Hide resolved
fabtests/benchmarks/rma_pingpong.c Outdated Show resolved Hide resolved
fabtests/common/shared.c Outdated Show resolved Hide resolved
fabtests/common/shared.c Outdated Show resolved Hide resolved
fabtests/common/shared.c Outdated Show resolved Hide resolved
fabtests/common/shared.c Outdated Show resolved Hide resolved
RMA latency test for write and writedata operations.

* Write: polls receive buffer on receive side
* Writedata: polls for completions on receiver side

Signed-off-by: Eric Raut <[email protected]>
@rauteric rauteric force-pushed the fabtests_rma_pingpong_squashed branch from 27bf388 to e5828ed Compare December 6, 2023 18:41
@rauteric
Copy link
Contributor Author

rauteric commented Dec 6, 2023

Resolved comments from @aingerson

@shijin-aws
Copy link
Contributor

bot:aws:retest

@shijin-aws
Copy link
Contributor

bot:aws:retest

@j-xiong
Copy link
Contributor

j-xiong commented Dec 6, 2023

The failure with DMABUF-Tests was due to failure of a test node. Restarted Intel CI run.

Copy link
Contributor

@aingerson aingerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!

@shijin-aws shijin-aws merged commit 7a030eb into ofiwg:main Dec 7, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants