Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prov/efa: Update lttng directions, specify glibc version requirement #9616

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

a-szegel
Copy link
Contributor

No description provided.

@a-szegel a-szegel requested review from darrylabbate and a team November 28, 2023 18:02
@darrylabbate
Copy link
Member

You can just add glibc >= 2.28 to the Prerequisites section of the doc (glib2-devel on AL2). The outdated glibc on AL2 is a common issue.

@@ -8,6 +8,9 @@ pages](https://lttng.org/man/).

## Installation

> [!NOTE]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be part of the prerequisites?

@a-szegel a-szegel force-pushed the update-lttng-directions branch from cc329f2 to 9d71896 Compare November 28, 2023 18:22
@a-szegel a-szegel requested a review from shijin-aws November 28, 2023 18:22
@darrylabbate
Copy link
Member

Out of scope, but I should probably just add my build script for LTTng 2.13+ and Babeltrace 2 as a "quick start." LTTng >= 2.13 can be easily installed via the system package manager for most relevant distros, but there are exceptions like AL2.

@a-szegel a-szegel force-pushed the update-lttng-directions branch from 9d71896 to beec32f Compare November 28, 2023 18:27
@a-szegel
Copy link
Contributor Author

These seem to be non-AL2 specific.

@a-szegel a-szegel force-pushed the update-lttng-directions branch from beec32f to f0e89ff Compare November 28, 2023 18:50
Comment on lines 20 to 21
* [glib2-devel] (glibc 2.28 is required for babeltrace2)
* [elfutils-devel] (required for babeltrace2)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Provide a link or remove the link formatting.
  • Use the generic names for the packages. glib2-devel and elfutils-devel are specific to yum.
  • Babeltrace2's dependency is pedantically GLib, not glibc (ref)
  • I would also recommend moving these to the section on Babeltrace2, since it's not a hard requirement for LTTng-UST (i.e. you can analyze LTTng traces using other tools, like Trace Compass)
Suggested change
* [glib2-devel] (glibc 2.28 is required for babeltrace2)
* [elfutils-devel] (required for babeltrace2)
* [GLib](https://developer.gnome.org/glib/) >= 2.28
* [elfutils](https://sourceware.org/elfutils/) >= 0.154

@darrylabbate
Copy link
Member

These seem to be non-AL2 specific.

The dependencies themselves are not specific to AL2. My point was that the package manager will resolve them for you - AL2 being kind of an outlier since LTTng 2.13 isn't available via yum. It's only tangentially relevant to this PR.

@a-szegel a-szegel force-pushed the update-lttng-directions branch from f0e89ff to 31f72c3 Compare December 4, 2023 20:55
Specify glibc version requirement for AL2.
Specify elfutils-devel requirement for AL2.

Signed-off-by: Seth Zegelstein <[email protected]>
@a-szegel a-szegel force-pushed the update-lttng-directions branch from 31f72c3 to 20d8e24 Compare December 4, 2023 20:55
@shijin-aws shijin-aws merged commit 4b25d7b into ofiwg:main Dec 5, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants