-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prov/efa: Update lttng directions, specify glibc version requirement #9616
Conversation
You can just add glibc >= 2.28 to the Prerequisites section of the doc ( |
prov/efa/docs/lttng.md
Outdated
@@ -8,6 +8,9 @@ pages](https://lttng.org/man/). | |||
|
|||
## Installation | |||
|
|||
> [!NOTE] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be part of the prerequisites?
cc329f2
to
9d71896
Compare
Out of scope, but I should probably just add my build script for LTTng 2.13+ and Babeltrace 2 as a "quick start." LTTng >= 2.13 can be easily installed via the system package manager for most relevant distros, but there are exceptions like AL2. |
9d71896
to
beec32f
Compare
These seem to be non-AL2 specific. |
beec32f
to
f0e89ff
Compare
prov/efa/docs/lttng.md
Outdated
* [glib2-devel] (glibc 2.28 is required for babeltrace2) | ||
* [elfutils-devel] (required for babeltrace2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Provide a link or remove the link formatting.
- Use the generic names for the packages.
glib2-devel
andelfutils-devel
are specific toyum
. - Babeltrace2's dependency is pedantically GLib, not glibc (ref)
- I would also recommend moving these to the section on Babeltrace2, since it's not a hard requirement for LTTng-UST (i.e. you can analyze LTTng traces using other tools, like Trace Compass)
* [glib2-devel] (glibc 2.28 is required for babeltrace2) | |
* [elfutils-devel] (required for babeltrace2) | |
* [GLib](https://developer.gnome.org/glib/) >= 2.28 | |
* [elfutils](https://sourceware.org/elfutils/) >= 0.154 |
The dependencies themselves are not specific to AL2. My point was that the package manager will resolve them for you - AL2 being kind of an outlier since LTTng 2.13 isn't available via |
f0e89ff
to
31f72c3
Compare
Specify glibc version requirement for AL2. Specify elfutils-devel requirement for AL2. Signed-off-by: Seth Zegelstein <[email protected]>
31f72c3
to
20d8e24
Compare
No description provided.