send CORS headers for OPTIONS requests #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1117 +/- ##
==========================================
+ Coverage 72.38% 72.39% +0.01%
==========================================
Files 187 187
Lines 14959 14959
==========================================
+ Hits 10828 10830 +2
+ Misses 3598 3597 -1
+ Partials 533 532 -1 ☔ View full report in Codecov by Sentry. |
|
Please re-generate code with Everything else is LGTM. Thanks! |
Currently CORS validation fails, due to OPTIONS Requests having a 405 response code. This commit corrects this by sending the proper CORS headers and a success status code on an OPTIONS request.
|
Should GitHub complete "processing updates" within this decade, this should be resolved :) |
tdakkota
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CORS validation fails, due to OPTIONS Requests having a 405 response code. This commit corrects this by sending the proper CORS headers and a success status code on an OPTIONS request.