Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ir): properly handle stringified optionals #1132

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Dec 8, 2023

Fixes #1130

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7735bac) 72.42% compared to head (e056c7b) 72.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1132      +/-   ##
==========================================
+ Coverage   72.42%   72.44%   +0.01%     
==========================================
  Files         187      187              
  Lines       15009    15009              
==========================================
+ Hits        10871    10873       +2     
+ Misses       3605     3604       -1     
+ Partials      533      532       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdakkota tdakkota force-pushed the fix/optional-stringified branch from 263d6b1 to fcbe32f Compare December 8, 2023 08:24
@tdakkota tdakkota force-pushed the fix/optional-stringified branch from fcbe32f to e056c7b Compare December 8, 2023 08:35
@tdakkota tdakkota marked this pull request as ready for review December 8, 2023 08:47
@ernado ernado merged commit 1bd52a0 into ogen-go:main Dec 8, 2023
14 checks passed
@tdakkota tdakkota deleted the fix/optional-stringified branch May 21, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gen: optional value encoder does not properly handle string formats
2 participants