Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gen): set status and code attr per spec #1352

Merged
merged 8 commits into from
Dec 1, 2024
Merged

feat(gen): set status and code attr per spec #1352

merged 8 commits into from
Dec 1, 2024

Conversation

ernado
Copy link
Member

@ernado ernado commented Nov 30, 2024 •
edited
Loading

https://opentelemetry.io/docs/specs/semconv/http/http-spans/#status

  • Do not set span status on 1XX, 2XX, 3XX
  • Set status code attribute for metrics and spans

Fix #1351

@ernado ernado marked this pull request as draft November 30, 2024 09:10
@ernado ernado changed the title feat(gen): set status and code attr feat(gen): set status and code attr per spec Nov 30, 2024
@ernado ernado marked this pull request as ready for review November 30, 2024 09:40
@ernado ernado requested a review from tdakkota November 30, 2024 09:40
tdakkota
tdakkota requested changes Dec 1, 2024
View reviewed changes
gen/_template/handlers.tmpl Outdated Show resolved Hide resolved
gen/_template/handlers.tmpl Outdated Show resolved Hide resolved
@ernado ernado requested a review from tdakkota December 1, 2024 03:47
@tdakkota tdakkota merged commit 1654875 into main Dec 1, 2024
14 checks passed
@tdakkota tdakkota deleted the feat/set-status branch December 1, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdakkota tdakkota tdakkota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: do not set error on 4xx codes
2 participants
@ernado @tdakkota