no_std, std-compatible type aliases, docs
#35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…argo rdme` support, README spelling, grammar, etc.
|
Will fix the failing tests asap. |
|
Hi @virtualritz, just letting you know that I haven't forgotten your PR. I would like to merge a quite substantial refactoring first and then I'll rebase your PR on it |
|
I didn't think you did, I saw you where very busy in other branches. 😁 |
|
Hi @virtualritz,
I'll rebase this branch on latest main commit and extract two commits for the two first points |
ogxd
added a commit
that referenced
this pull request
Dec 25, 2023
* Added `Clone` and `Debug` traits to `GxHasher` and `GxBuildHasher`. * Updated deps. * Made clippy (almost) happy. * rustfmt. * Added no_std compatibility, removed `Gx` prefix from type aliases, `cargo rdme` support, README spelling, grammar, etc. * `cargo rdme` options * Added cargo features section in docs. * Fixed tests and doc tests. * Missing line-breaks. --------- Co-authored-by: Olivier Giniaux <[email protected]>
ogxd
added a commit
that referenced
this pull request
Dec 25, 2023
* Added `Clone` and `Debug` traits to `GxHasher` and `GxBuildHasher`. * Updated deps. * Made clippy (almost) happy. * rustfmt. * Added no_std compatibility, removed `Gx` prefix from type aliases, `cargo rdme` support, README spelling, grammar, etc. * `cargo rdme` options * Added cargo features section in docs. * Fixed tests and doc tests. * Missing line-breaks. --------- Co-authored-by: Olivier Giniaux <[email protected]>
ogxd
added a commit
that referenced
this pull request
Dec 25, 2023
* Added `Clone` and `Debug` traits to `GxHasher` and `GxBuildHasher`. * Updated deps. * Made clippy (almost) happy. * rustfmt. * Added no_std compatibility, removed `Gx` prefix from type aliases, `cargo rdme` support, README spelling, grammar, etc. * `cargo rdme` options * Added cargo features section in docs. * Fixed tests and doc tests. * Missing line-breaks. --------- Co-authored-by: Olivier Giniaux <[email protected]>
This was referenced Dec 25, 2023
Closed
|
Here I have extracted two PRs from this one: Don't hesitate to leave comments I'll keep these PRs open for a few days before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no_stdsupport.Gxprfix from the convenience type aliases and addedHashMapExtcompatibility trait.READMEtolib.rs.cargo rdme.