Experiment with simd_masked_load to read beyond without undefined behavior #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogxd
force-pushed
the
read-beyond-no-ub
branch
from
b7705c9 to
ce077bf
Compare
RalfJung
reviewed
Nov 6, 2024
src/gxhash/platform/arm.rs
Outdated
|
|
||
| let indices = vld1q_s8([0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15].as_ptr()); | ||
| let mask = vreinterpretq_s8_u8(vcgtq_s8(vdupq_n_s8(len as i8), indices)); | ||
| std::intrinsics::simd::simd_masked_load(mask, data as *const i8, vdupq_n_s8(len as i8)) |
There was a problem hiding this comment.
So do I understand correctly that it would be valid for LLVM to basically emit the same assembly as before, but somehow it doesn't?
I'm not a codegen expert so I have no idea whether this is just hard for LLVM to do or something they could reasonably fix. Maybe it'd be worth making an LLVM bugreport about this? (We can try to find some people that could help nail down the core issue here, if you are interested.)
# Conflicts: # benches/throughput/aarch64.svg # benches/throughput/x86_64-hybrid.svg # benches/throughput/x86_64.svg
ogxd
force-pushed
the
read-beyond-no-ub
branch
from
9a04834 to
57ddc68
Compare
ogxd
force-pushed
the
read-beyond-no-ub
branch
from
5cefdf3 to
61da550
Compare
ogxd
force-pushed
the
read-beyond-no-ub
branch
from
61da550 to
259e8a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.