node-i18n v0.2 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 27, 2011 10:48
…ove `I18n.factory`.
|
Thanks a ton! I'm really loving the changes, I wrote this very quickly for something to do and neglected it after that. We should continue to work on it. :) |
|
Thanks for the quick merge! Sure, we could definitely keep working on it...were you thinking of adding anything in particular? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made some improvements and optimizations to
node-i18n, and bumped the version to 0.2. Here's a brief synopsis of my changes:I18n#t. I've also renamed this method toI18n#interpolatefor clarity.I18nfunction now works as both a factory and a constructor, removing the need for theI18n.factorymethod.node examples/templating.jsshould now run without throwing any exceptions.