Replaced older components in the useFileManager with shadcn component #10344

NikhilA8606 · 2025-01-31T17:34:24Z

Replaced all older components with shadCN components

Used Input ui shadcn component instead of TextFormFiled
Used Label instead of passing as props
Part of Replacing older UI components with new UI components #10048

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Enhanced localization support with new translation keys for file management actions.
- Improved user input validation and feedback messages.
Localization
- Added new English translation strings for file renaming, archiving, and input validation.
- Implemented internationalization for dialog messages and input prompts.
UI Improvements
- Updated input components to support better user interaction and error handling.

…ager file

coderabbitai · 2025-01-31T17:34:31Z

Walkthrough

This pull request focuses on enhancing localization and user interface components for file management. The changes include adding new translation keys to the English localization file (en.json) and updating the useFileManager.tsx hook to use these translations. The modifications replace a specific form field component with a more generic input component and improve internationalization by utilizing the i18next translation function for error messages and dialog text.

Changes

File	Change Summary
`public/locale/en.json`	Added 6 new localization keys for file naming, archiving, and input validation
`src/hooks/useFileManager.tsx`	Replaced `TextFormField` with `Input` component, updated dialog text to use translations
`src/components/Files/FileUpload.tsx`	Replaced `TextFormField` with `Label` and `Input` components, updated error handling

Sequence Diagram

sequenceDiagram
    participant User
    participant FileManager
    participant InputComponent
    participant TranslationService

    User->>FileManager: Interact with file management
    FileManager->>TranslationService: Request translations
    TranslationService-->>FileManager: Provide translated messages
    FileManager->>InputComponent: Use generic Input component
    User->>InputComponent: Enter file name/reason
    InputComponent->>FileManager: Validate input
    FileManager->>TranslationService: Get validation error messages
    TranslationService-->>FileManager: Return translated error messages

Possibly related PRs

Patient files #9787: This PR adds new key-value pairs to the public/locale/en.json file, which is directly related to the localization changes made in the main PR.
Fix: Replace InputWithError and InputErrors components with ShadCN’s components directly. #9847: Similar to the main PR, this PR also adds a new entry to the public/locale/en.json file, enhancing localization support.
Update localization keys for photo capture to improve clarity (Follow up PR #10018) #10085: This PR updates localization keys in the public/locale/en.json file, which aligns with the localization enhancements in the main PR.

Suggested labels

needs review, tested

Suggested reviewers

rithviknishad

Poem

🐰 A rabbit's tale of code so bright,
Translations dancing with delight!
Input fields now sleek and clean,
Localization reigns supreme!
Hop, hop, hooray for dev's might! 🌟

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5298737 and 3b50208.

📒 Files selected for processing (1)

src/components/Files/FileUpload.tsx (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: cypress-run (1)

🔇 Additional comments (3)

src/components/Files/FileUpload.tsx (3)

8-9: LGTM! Import changes align with PR objectives.

The addition of shadcn UI components (Input and Label) aligns with the PR's goal of modernizing the component usage.

280-289: LGTM! Clean implementation of shadcn components.

The replacement of TextFormField with Label and Input components is well-implemented:

Maintains all necessary functionality

Properly uses i18n for internationalization

Correctly configures input attributes and event handling

290-292: LGTM! Error handling implementation is clean and effective.

The error message display is well-implemented with:

Proper conditional rendering

Appropriate error styling

Clear visual feedback

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-01-31T17:34:42Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`3b50208`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/679d15c537857300087a1019
😎 Deploy Preview	https://deploy-preview-10344--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

AdityaJ2305 · 2025-01-31T17:44:08Z

@NikhilA8606 TextFormField here
https://github.com/ohcnetwork/care_fe/blob/6f77a6947e26e2c0c6e80e0dfd5920f13c08b101/src/components/Files/FileUpload.tsx

rithviknishad · 2025-01-31T17:49:03Z

@NikhilA8606 TextFormField here
https://github.com/ohcnetwork/care_fe/blob/6f77a6947e26e2c0c6e80e0dfd5920f13c08b101/src/components/Files/FileUpload.tsx

let's do this

NikhilA8606 · 2025-01-31T17:53:17Z

@NikhilA8606 TextFormField here
https://github.com/ohcnetwork/care_fe/blob/6f77a6947e26e2c0c6e80e0dfd5920f13c08b101/src/components/Files/FileUpload.tsx

let's do this

Sure

github-actions · 2025-02-01T02:09:14Z

@NikhilA8606 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

NikhilA8606 added 2 commits January 31, 2025 17:01

Replaced all old ui components with shadcn ui component in useFileMan…

d744dcb

…ager file

Texts are kept in i18n file

5298737

NikhilA8606 requested a review from a team as a code owner January 31, 2025 17:34

rithviknishad approved these changes Jan 31, 2025

View reviewed changes

rithviknishad added the changes required label Jan 31, 2025

Replaced TextFormField with Input component in FileUpload file

3b50208

rithviknishad approved these changes Feb 1, 2025

View reviewed changes

rithviknishad merged commit 4f295a0 into ohcnetwork:develop Feb 1, 2025
15 checks passed

rithviknishad removed the changes required label Feb 1, 2025

rithviknishad assigned NikhilA8606 Feb 1, 2025

This was referenced Feb 1, 2025

Enhancements to Encounter Discussion/Notes | Fix Translation #10156

Open

Get error for specific inputs when updated #10446

Merged

File Archiving, Perms, Card Layout #10384

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replaced older components in the useFileManager with shadcn component #10344

Replaced older components in the useFileManager with shadcn component #10344

NikhilA8606 commented Jan 31, 2025 •

edited by rithviknishad

Loading

coderabbitai bot commented Jan 31, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Jan 31, 2025 •

edited

Loading

AdityaJ2305 commented Jan 31, 2025

rithviknishad commented Jan 31, 2025

NikhilA8606 commented Jan 31, 2025

github-actions bot commented Feb 1, 2025

Replaced older components in the useFileManager with shadcn component #10344

Replaced older components in the useFileManager with shadcn component #10344

Conversation

NikhilA8606 commented Jan 31, 2025 • edited by rithviknishad Loading

Replaced all older components with shadCN components

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Jan 31, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Jan 31, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

AdityaJ2305 commented Jan 31, 2025

rithviknishad commented Jan 31, 2025

NikhilA8606 commented Jan 31, 2025

github-actions bot commented Feb 1, 2025

NikhilA8606 commented Jan 31, 2025 •

edited by rithviknishad

Loading

coderabbitai bot commented Jan 31, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Jan 31, 2025 •

edited

Loading