Fixed : Newly Added Patient Is Not Instantly Visible in the patient-switcher #10819

Mahendar0701 · 2025-02-26T07:43:06Z

Proposed Changes

Fixes Newly Added Patient Is Not Instantly Visible in the Patient List of patient dashboard #10723
Change 1
Change 2
More?

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Enhanced the patient registration process to ensure the patient list reflects the latest additions immediately.
- Improved user experience by automatically retaining the newly registered patient's details for easier future reference.

…lected patient in localStorage

coderabbitai · 2025-02-26T07:43:14Z

Walkthrough

This change enhances the patient registration process by ensuring that after a patient is created, the system invalidates cached patient data and updates local storage with the new patient’s information. These modifications improve data consistency and state management without altering any exported or public entity declarations.

Changes

File	Change Summary
`src/pages/PublicAppointments/PatientRegistration.tsx`	Adds call to `queryClient.invalidateQueries({ queryKey: ["patients"] })` to refresh cached patient data and stores the new patient's data in local storage.

Sequence Diagram(s)

sequenceDiagram
    participant UI as PatientRegistration
    participant API as Server
    participant QueryCache as QueryClient
    participant Storage as localStorage

    UI->>API: createPatient(data)
    API-->>UI: success(responseData)
    UI->>QueryCache: invalidateQueries(["patients"])
    UI->>Storage: setItem("selectedPatient", JSON.stringify(responseData))

Possibly related PRs

Fix: Bugs in Public Patient Registration Form #10462 – Modifies handling of patient gender and form initialization in PatientRegistration.tsx, closely related to the changes in query invalidation and local storage updates.
fixes dob formatting of patient registration #10135 – Alters the date-of-birth processing within the PatientRegistration component, indicating direct code-level modifications in the same area.
Confirm Alert for Patient Registration #10205 – Introduces modifications using the useNavigationPrompt hook in the patient registration process, which relates code-wise to handling mutations in the PatientRegistration component.

Suggested labels

needs review, tested

Suggested reviewers

rithviknishad
Jacobjeevan

Poem

Hopping through code in the soft moonlight,
I nibbled some queries to make them bright.
Cached tales are cleared with a swift little jump,
Storing new patients without a single bump.
With twitching whiskers, I celebrate each line—
CodeRabbit’s cheer makes everything fine!
🐰✨

Tip

CodeRabbit's docstrings feature is now available as part of our Pro Plan! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ffedec and aa5e987.

📒 Files selected for processing (1)

src/pages/PublicAppointments/PatientRegistration.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: cypress-run (1)

🔇 Additional comments (2)

src/pages/PublicAppointments/PatientRegistration.tsx (2)

181-183: Good implementation of query invalidation!

Invalidating the patients query is essential to ensure the patient-switcher component displays the newly created patient immediately, addressing the issue mentioned in the PR title. This ensures any components relying on patient data will refetch and receive the up-to-date information.

185-185: Excellent addition of localStorage persistence

Storing the newly created patient's data in localStorage ensures the patient-switcher can immediately access the selected patient without waiting for a refetch. This complements the query invalidation by providing immediate access to the new patient's information.

✨ Finishing Touches

📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-02-26T07:43:24Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`dbb9069`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67bec77d0104cc00085a670a
😎 Deploy Preview	https://deploy-preview-10819.preview.ohc.network
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bodhish · 2025-02-26T17:00:13Z

src/pages/PublicAppointments/PatientRegistration.tsx

      publish("patient:upsert", data);
+      localStorage.setItem("selectedPatient", JSON.stringify(data));


Why should we store the patient data in localstorage? @Jacobjeevan @rithviknishad ?
If its for the ID we should probably add patient id to the routes. The data would be avilable in the context right 🤔

I assumed this was a requirement, since I've been seeing caching things to local storage for all public patient related workflow since the beginning 😬

We can remove this local storage.

@Mahendar0701 go ahead and do that here, patient-switcher and in PatientUserProvider.

nihal467 · 2025-02-27T12:28:28Z

@rithviknishad is it ready for review, seem like a discussion going on !

Mahendar0701 · 2025-02-27T13:49:05Z

@rithviknishad let me know if I need to modify anything in this PR

rithviknishad · 2025-02-27T14:23:15Z

@Jacobjeevan

Enhance patient registration: invalidate patient queries and store se…

aa5e987

…lected patient in localStorage

Mahendar0701 requested a review from a team as a code owner February 26, 2025 07:43

Mahendar0701 mentioned this pull request Feb 26, 2025

Fix : Patient search bar auto focus on visiting #10736

Open

6 tasks

Trigger

dbb9069

Jacobjeevan approved these changes Feb 26, 2025

View reviewed changes

Jacobjeevan added needs testing needs review labels Feb 26, 2025

rithviknishad approved these changes Feb 26, 2025

View reviewed changes

rithviknishad added reviewed reviewed by a core member and removed needs review labels Feb 26, 2025

bodhish reviewed Feb 26, 2025

View reviewed changes

nihal467 added the question Further information is requested label Feb 27, 2025

Mahendar0701 requested a review from Jacobjeevan February 27, 2025 15:02

Jacobjeevan added changes required and removed question Further information is requested needs testing reviewed reviewed by a core member labels Feb 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed : Newly Added Patient Is Not Instantly Visible in the patient-switcher #10819

Fixed : Newly Added Patient Is Not Instantly Visible in the patient-switcher #10819

Mahendar0701 commented Feb 26, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 26, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Feb 26, 2025 •

edited

Loading

bodhish Feb 26, 2025

rithviknishad Feb 26, 2025

Jacobjeevan Feb 28, 2025 •

edited

Loading

nihal467 commented Feb 27, 2025

Mahendar0701 commented Feb 27, 2025

rithviknishad commented Feb 27, 2025

		publish("patient:upsert", data);
		localStorage.setItem("selectedPatient", JSON.stringify(data));

Fixed : Newly Added Patient Is Not Instantly Visible in the patient-switcher #10819

Are you sure you want to change the base?

Fixed : Newly Added Patient Is Not Instantly Visible in the patient-switcher #10819

Conversation

Mahendar0701 commented Feb 26, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Feb 26, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Feb 26, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

bodhish Feb 26, 2025

Choose a reason for hiding this comment

rithviknishad Feb 26, 2025

Choose a reason for hiding this comment

Jacobjeevan Feb 28, 2025 • edited Loading

Choose a reason for hiding this comment

nihal467 commented Feb 27, 2025

Mahendar0701 commented Feb 27, 2025

rithviknishad commented Feb 27, 2025

Mahendar0701 commented Feb 26, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 26, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 26, 2025 •

edited

Loading

Jacobjeevan Feb 28, 2025 •

edited

Loading