Tooltip added for treating docter skills in Patient details page #9254

Mahendar0701 · 2024-11-29T17:47:09Z

Proposed Changes

Fixes Tooltip for Treating doctor skills in Patient Details Page #9253
Added tooltip for treating docter in patient details page

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Enhanced display of treating physician's skills with tooltips for better user experience.
- Improved state management for assigned volunteers.
- Streamlined error handling for volunteer assignments.
Bug Fixes
- Refined response handling in approval and patient transfer processes to ensure accurate notifications.

coderabbitai · 2024-11-29T17:47:16Z

Walkthrough

The changes in this pull request primarily focus on the PatientHome component, enhancing the display of treating physician skills by replacing a <p> tag with a <span> tag that includes a tooltip for skills exceeding three. The state management for assignedVolunteer has been refined, ensuring it initializes correctly and updates with changes in patientData. Error handling has been improved, particularly in the volunteer assignment process. Additionally, the handleApproval and handlePatientTransfer functions have been modified to provide clearer response handling and notifications based on the success of operations.

Changes

File	Change Summary
`src/components/Patient/PatientHome.tsx`	Updated the rendering of physician skills to use a `<span>` with tooltip; refined state handling for `assignedVolunteer`; improved error handling; modified `handleApproval` and `handlePatientTransfer` functions for better response management.

Assessment against linked issues

Objective	Addressed	Explanation
Tooltip for Treating doctor skills in Patient Details Page (#9253)	✅

Possibly related PRs

Added dynamic lock icon and strong types #9006: This PR modifies the PatientHome component, similar to the main PR, by enhancing type safety and updating the rendering logic.
Remove redundant "Add Consultation" button #9095: This PR also involves changes to the PatientHome component, specifically altering the rendering logic related to the "Add Consultation" button.

Suggested labels

needs testing, good to merge

Suggested reviewers

rithviknishad
shivankacker

Poem

In the home of patients, skills now shine,
With tooltips that sparkle, oh so fine.
Volunteers assigned, with care they stay,
Handling errors, come what may.
A better UI, for all to see,
Hopping along, as happy as can be! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c7593b5 and c754618.

📒 Files selected for processing (1)

src/components/Patient/PatientHome.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/components/Patient/PatientHome.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2024-11-29T17:47:24Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`daaef79`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/674da3774f07db000825659d
😎 Deploy Preview	https://deploy-preview-9254--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c58de17 and c7593b5.

📒 Files selected for processing (1)

src/components/Patient/PatientHome.tsx (1 hunks)

🧰 Additional context used

🪛 Biome (1.9.4)

src/components/Patient/PatientHome.tsx

[error] 385-385: Missing key property for this element in iterable.

The order of the items may change, and having a key can help React identify which item was moved.
Check the React documentation.

(lint/correctness/useJsxKeyInIterable)

🔇 Additional comments (2)

src/components/Patient/PatientHome.tsx (2)

Line range hint 48-54: LGTM: Clean state management implementation

The state management for assignedVolunteer is well-implemented:

Proper initialization with patientData.assigned_to_object
Clean useEffect hook to sync with patientData changes

🧰 Tools

🪛 Biome (1.9.4)

[error] 385-385: Missing key property for this element in iterable.

The order of the items may change, and having a key can help React identify which item was moved.
Check the React documentation.

(lint/correctness/useJsxKeyInIterable)

379-389: Implementation successfully meets PR objectives

The tooltip implementation for treating doctor skills:

Shows a summary when there are more than 3 skills
Displays the full list on hover
Provides a clean and intuitive user experience

🧰 Tools

🪛 Biome (1.9.4)

[error] 385-385: Missing key property for this element in iterable.

The order of the items may change, and having a key can help React identify which item was moved.
Check the React documentation.

(lint/correctness/useJsxKeyInIterable)

src/components/Patient/PatientHome.tsx

Mahendar0701 · 2024-12-02T11:43:29Z

@rithviknishad are there any changes required for this PR?

Jacobjeevan · 2024-12-02T12:06:48Z

@rithviknishad are there any changes required for this PR?

Just needs testing 👍

tooltip-in-patient

c7593b5

Mahendar0701 requested a review from a team as a code owner November 29, 2024 17:47

coderabbitai bot reviewed Nov 29, 2024

View reviewed changes

src/components/Patient/PatientHome.tsx Outdated Show resolved Hide resolved

added coderabbit suggestions

c754618

rithviknishad approved these changes Nov 30, 2024

View reviewed changes

rithviknishad added the needs testing label Nov 30, 2024

Mahendar0701 added 3 commits November 30, 2024 10:14

Merge branch 'develop' into tooltip-docter-skills

0ba42c5

Merge branch 'develop' into tooltip-docter-skills

4a68e0d

Merge branch 'develop' into tooltip-docter-skills

cfaa3f6

github-actions bot added needs-triage question Further information is requested labels Dec 2, 2024

Jacobjeevan removed question Further information is requested needs-triage labels Dec 2, 2024

Jacobjeevan approved these changes Dec 2, 2024

View reviewed changes

Merge branch 'develop' into tooltip-docter-skills

daaef79

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tooltip added for treating docter skills in Patient details page #9254

Tooltip added for treating docter skills in Patient details page #9254

Mahendar0701 commented Nov 29, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 29, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Nov 29, 2024 •

edited

Loading

coderabbitai bot left a comment

Mahendar0701 commented Dec 2, 2024

Jacobjeevan commented Dec 2, 2024

Tooltip added for treating docter skills in Patient details page #9254

Are you sure you want to change the base?

Tooltip added for treating docter skills in Patient details page #9254

Conversation

Mahendar0701 commented Nov 29, 2024 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Nov 29, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Nov 29, 2024 • edited Loading

✅ Deploy Preview for care-ohc ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Mahendar0701 commented Dec 2, 2024

Jacobjeevan commented Dec 2, 2024

Mahendar0701 commented Nov 29, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 29, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Nov 29, 2024 •

edited

Loading