Issues/8607/review missed #9259
Conversation
WalkthroughThe pull request includes changes to the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
src/components/Patient/ManagePatients.tsx (1)
642-658: Consider using i18n for review notification textThe implementation nicely handles both missed and upcoming reviews with clear time indicators. However, the text strings should be internationalized for consistency.
Consider using i18n translations:
- ? `Review Missed (${Math.abs(dayjs().diff(dayjs(patient.review_time), "days"))} days ago)` - : `Review Due in (${Math.abs(dayjs(patient.review_time).diff(dayjs(), "days"))} days)` + ? t("review_missed_days_ago", { + days: Math.abs(dayjs().diff(dayjs(patient.review_time), "days")) + }) + : t("review_due_in_days", { + days: Math.abs(dayjs(patient.review_time).diff(dayjs(), "days")) + })
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
package.json(1 hunks)src/components/Patient/ManagePatients.tsx(2 hunks)
🔇 Additional comments (1)
src/components/Patient/ManagePatients.tsx (1)
Line range hint 631-641: LGTM! Good cleanup of commented code.
Removing commented-out code improves code maintainability.
package.json
Outdated
| @@ -96,7 +96,7 @@ | |||
| "tailwind-merge": "^2.5.4", | |||
| "tailwindcss-animate": "^1.0.7", | |||
| "use-keyboard-shortcut": "^1.1.6", | |||
| "xlsx": "^0.18.5" | |||
| "xlsx": "https://cdn.sheetjs.com/xlsx-0.20.3/xlsx-0.20.3.tgz" | |||
There was a problem hiding this comment.
@Sancharisingh this change seems to be unrelated to the linked PR. If you meant to solve #9183, please raise a separate PR solving that alone.
There was a problem hiding this comment.
@rithviknishad, I’ve removed the changes related to SheetJS. Please review now and let me know if further adjustments are needed.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Proposed Changes
Time left for review if the review is upcoming.
Missed since [X] days if the review time has passed
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit
New Features
Chores
Dependencies
xlsxpackage version from^0.18.5to^0.20.3for improved functionality and potential new features.