A few changes #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation gets a proper "stretch" of the dots.
…lly. Also changed animations to use block-based mechanisms. Cleaned up a little bit of code.
…rovided slider graphic. It's not an ideal iOS 7 improvement (nor a complete one), but it's something for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change that would be useful to pull would be from commit:
barz@56f8744
to fix a redraw problem when the device rotation changes. In my case, the scrubber was at the bottom of a portrait view, but when the device went landscape while the bar still worked the dots didn't redraw and so it looked weird.
The other changes are up to you to pull. I don't know if it was important for you to maintain old OS version support, but otherwise it's now preferred to adopt the block-based animations. I added the one method to "flash" the callout for the particular use-case I had.