#2549 - sass deprecation issue #2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebinSong
commented
Jan 29, 2025
Comment on lines
-29
to
-58
| @mixin removeSideCardPadding { | ||
| width: calc(100% + 2rem); | ||
| margin-left: -0.5rem; | ||
| margin-right: -0.5rem; | ||
|
|
||
| @include tablet { | ||
| width: calc(100% + 3rem); | ||
| margin-left: -1.5rem; | ||
| margin-right: -1.5rem; | ||
| } | ||
|
|
||
| @include desktop { | ||
| width: calc(100% + 5rem); | ||
| margin-left: -2.5rem; | ||
| margin-right: -2.5rem; | ||
| } | ||
| } | ||
|
|
||
| @mixin removeTopCardPadding { | ||
| margin-top: -1.5rem; | ||
|
|
||
| @include tablet { | ||
| margin-top: -1.5rem; | ||
| } | ||
|
|
||
| @include desktop { | ||
| margin-top: -2.5rem; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
These 2 mixins are duplicated in this file. So removing them.
SebinSong
commented
Jan 29, 2025
Comment on lines
-139
to
-142
| // formerly in _colors.scss, moved here so that | ||
| // @import "_variables"; in scoped styles in vue components | ||
| // doesn't result in repeated CSS generated | ||
|
|
There was a problem hiding this comment.
This comment is not relevant anymore. So removed it.
SebinSong
commented
Jan 29, 2025
Comment on lines
-29
to
-35
| // Breakpoints | ||
| // // Same as JS breakpoints at breakpoints.js | ||
| // TODO: Redefine the breakpoints with @mmbotelho in a next task. | ||
| $gap: 1rem; | ||
| $tablet: 769px; | ||
| $desktop: 1200px; | ||
|
|
There was a problem hiding this comment.
breakpoint variables have now been moved to _mixins.scss which is @forwarded by this file now (L40 below). This ensures any .vue file that imports/uses variables.scss in its scoped style block can safely access these variables, just like prior to this PR.
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
sebin/task/#2549-sass-deprecation-issue
|
| Run status |
|
| Run duration | 10m 52s |
| Commit |
|
| Committer | Sebin Song |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
112
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2549