Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve GI_VERSION update logic #2568

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Improve GI_VERSION update logic #2568

merged 2 commits into from
Jan 31, 2025

Conversation

corrideat
Copy link
Member

Closes #2562.

@corrideat corrideat requested a review from taoeffect January 30, 2025 12:47
@cypress Cypress
Copy link

cypress bot commented Jan 30, 2025 •
edited
Loading

group-income    Run #3852

Run Properties:  status check passed Passed #3852  •  git commit 2e6942c482 ℹ️: Merge 4afc475ff6bc2c6fd5fdc9f9e74dadaa80987dfa into 16893d5b1baaec27b706ca405d19...
Project group-income
Branch Review 2562-neither-browser-nor-service-worker-seems-to-use-new-gi_version-when-its-released
Run status status check passed Passed #3852
Run duration 11m 06s
Commit git commit 2e6942c482 ℹ️: Merge 4afc475ff6bc2c6fd5fdc9f9e74dadaa80987dfa into 16893d5b1baaec27b706ca405d19...
Committer Ricardo Iván Vieitez Parra
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 112
View all changes introduced in this branch ↗︎

@corrideat corrideat self-assigned this Jan 30, 2025
@taoeffect taoeffect mentioned this pull request Jan 30, 2025
Merged
taoeffect
taoeffect requested changes Jan 30, 2025
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review ready!

@corrideat corrideat force-pushed the 2562-neither-browser-nor-service-worker-seems-to-use-new-gi_version-when-its-released branch from a0bb3ab to 4afc475 Compare January 31, 2025 19:59
taoeffect
taoeffect approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @corrideat !

@taoeffect taoeffect merged commit 301cb86 into master Jan 31, 2025
4 checks passed
@taoeffect taoeffect deleted the 2562-neither-browser-nor-service-worker-seems-to-use-new-gi_version-when-its-released branch January 31, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoeffect taoeffect taoeffect approved these changes

Assignees

@corrideat corrideat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Neither browser nor service worker seems to use new GI_VERSION when it's released
2 participants
@corrideat @taoeffect