WIP: add Scala 2.12 and drop 2.10 support #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@okapies also tried this out. We are moving all our code to 2.12 and this is one of the last blockers. We will spend some time on getting this working in the near future. |
|
I see, thanks! |
|
Did a small investigation on this. Since the protocol has changed quite some from 0.8.2.1 to 1.0, 2.0 and beyond I would suggest that we start by supporting the message set/record format for 1.0. That would directly make it possible to remove 2.10 and add 2.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Scala 2.12 to
crossScalaVersionsand remove 2.10 due to dropped 2.10 support in Finagle.TODO: fix some compile errors.