Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve remote file uploading error indication #697

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

roll
Copy link
Collaborator

@roll roll commented Dec 18, 2024


@romicolman
This file seems to be not-properly encoded so frictionless-py can' read it. The only thing we can do at the moment is to improve an error message which is covered by this PR. Also, for now, it's not translated as the whole class of frictionless-py error messages need to be translated (it's just one case).

@roll roll requested review from guergana and romicolman December 18, 2024 10:15
@roll
Copy link
Collaborator Author

roll commented Dec 23, 2024

Thanks @guergana!

@roll roll merged commit 7a33f22 into main Dec 23, 2024
9 checks passed
@roll roll deleted the 678/fix-data-uploading-error branch December 23, 2024 09:22
Copy link
Collaborator

@romicolman romicolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just tested it with the file and I see the message. Thanks!

Uploading Captura de pantalla 2024-12-23 a la(s) 10.30.58 a. m..png…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error uploading data from Github - Research
3 participants