Now create-models.sh actually works #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that this PR is needed for the script to work. Thanks alex! :) The different versions of the Tightyl build fine and are all good to go (Printed the 5x6 model yesterday without problems). But apparently all of the base plates have weird artifacts and the STL files look broken (weird holes in the middle and little extra faces above the thumb cluster):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script create-models.sh was outdated and didn't work. I updated both the script and de *.patch files to generate automatically the .scad and .stl models. I had to fix the positioning of the screw inserts and the trrs-arduino holder. In the 6x6 model i also fixed the curvature so the first and last switches of every row can fit. I modified dactyl.clj so by default it generates a 4x5 model. README.MD should probably be updated too as the instructions are simpler now. Just need to install Clojure runtime, Leiningen, openscad and execute create-models.sh to get all the .stl ready to print.