Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slips Calculator Job #1384

Open
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

matulka
Copy link

@matulka matulka commented Mar 4, 2020

This pull request is supposed to solve the problem addressed in #1375

This is an updated version of #1068 which takes into account most of the comments for that PR. The main changed made is that in the initial PR slips were calculated for each of user's submissions and in this PR they are calculated only for the final submission.

Slips can be calculated both for the whole course (with an option to change which exact assignments should be included) and for individual assignments.

Calculating for the whole course

Calculating slips for an assignment

Output of the job is an .csv table which contains and SID, email and the amoung of slip days (or hours, minutes) used by a student. If a student has not used slip days, they will not be included in the table.

Calculating slips log

Output csv for a specific assignment

@cycomachead
Copy link

I think this will be great, but is it possible to have per-assignment slip time in the course CSV? So the header is ..., Total Slip {}, Assignment 1, Assignment 2, ...

@matulka
Copy link
Author

matulka commented Mar 7, 2020

@cycomachead Yeah sure, I will make it this week

@matulka
Copy link
Author

matulka commented Mar 24, 2020

@cycomachead Hey! Sorry for the delay. Check the course slips once again, I think I have made it the way you ask.
Also, I have noticed a problem that sometimes it displays an SID and sometimes it doesn't. I think this is connected to the fact that in the current architecture of the database SID and User are connected using Enrollment, so it supports the possibility of a student being enrolled in different courses with different SIDs. When calculating course slips, I take the SID connected to the current course, while when calculating assignment slips, I take the SID from some random enrollment associated with this student (because it is faster this way than manually looking through all enrollments and picking the right one, O(1) vs. O(n)). Should I fix this and change to picking the SID from a specific enrollment? This shouldn't be a problem if in the actual database all students have the same SIDs for each course.

@cycomachead
Copy link

@matulka Yes, this looks awesome now!! Thank you so much!! 🎉 🎊

@matulka
Copy link
Author

matulka commented Mar 26, 2020

@cycomachead Great! You are welcome :)

@cycomachead
Copy link

Any chance this could be merged soon or there is a way to run this, just to double check?

@cycomachead
Copy link

Can I get a bump on this? :) @matulka @rahularya50
Thanks!

@matulka
Copy link
Author

matulka commented Feb 22, 2021

Hey @cycomachead ! Sorry so much for a late response. The thing is that I have not been working on okpy since the May of last year, so I have no idea about the possibility of merging this :(

@cycomachead
Copy link

No worries, thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants