Add state parameter to AuthorizationCodeFlow.start #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajdeepnanua-okta
force-pushed
the
state_parameter
branch
from
3ccdb44 to
4b8969d
Compare
Comment on lines
72
to
74
| /** The default [CookieJar]. By default, it adds a DT cookie for identifying the device. | ||
| * To use the default [CookieJar] in OkHttp, set this to [CookieJar.NO_COOKIES] */ | ||
| var cookieJar: CookieJar by NoSetAfterGetWithLazyDefaultFactory { DeviceTokenCookieJar(clock) } | ||
| var cookieJar: CookieJar by NoSetAfterGetWithLazyDefaultFactory { CookieJar.NO_COOKIES } |
There was a problem hiding this comment.
How do you propose handling DeviceToken support for IDX? The documentation for this property no longer matches up with the implementation, so I'm wondering what the plan is?
Furthermore, if the cookieJar is set to NO_COOKIES, is this property even needed anymore?
There was a problem hiding this comment.
I decided to revert this, and instead fixed the issues with the following:
- Lazily loading DT cookie in DeviceTokenCookieJar to avoid crashes when users create OidcConfiguration in a Jetpack startup initializer.
- Attempting to reinitialize DeviceTokenProvider's storage by deleting the storage during Exception, and then recreating the storage.
These should fix most of the issues reported by users. The only exception being if the encryption key is itself corrupted, which can happen and has been reported as an issue for EncryptedSharedPreferences. But, that case should be much rarer than the issues addressed by the above two fixes.
rajdeepnanua-okta
force-pushed
the
state_parameter
branch
from
4b8969d to
8876a8b
Compare
mikenachbaur-okta
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds state parameter to AuthorizationCodeFlow.start as requested by #276.
This PR also fixes some issues related to DeviceTokenCookie initialization with the following:
These should fix most of the issues reported by users. The only exception being if the encryption key is itself corrupted, which can happen and has been reported as an issue for EncryptedSharedPreferences. But, that case should be much rarer than the issues addressed by the above two fixes.