Fix corrupt encrypted files caused by unwanted backup and restore #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+22
to
+34
| object TokenDbRecoveryUtil { | ||
| fun setupDatabaseRecovery() { | ||
| val context = ApplicationContextHolder.appContext | ||
| val defaultUncaughtExceptionHandler = Thread.getDefaultUncaughtExceptionHandler() | ||
| Thread.setDefaultUncaughtExceptionHandler { thread, exception -> | ||
| if (exception is SQLiteException) { | ||
| context.deleteDatabase(TokenDatabase.DB_NAME) | ||
| } else { | ||
| defaultUncaughtExceptionHandler?.uncaughtException(thread, exception) | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I decided to add this just in case things don't get fixed with the other fixes. This code should fix the token database if it ends up in an unrecoverable state, even if the encryption token is unchanged.
FeiChen-okta
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds recovery mechanisms for handling unexpected backup and restore with SDK storage files. Since SDK files in storage are encrypted using device keystore, they shouldn't be copied over to other devices, or even across app installations.
In addition to the recovery mechanisms, this PR also adds rules to exclude SDK files from automatic backup. I tested backup and restore using this to ensure sdk files aren't getting backed up: https://developer.android.com/identity/data/testingbackup