-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rocksdb Option Parameter Misspelling info #3045
base: dev
Are you sure you want to change the base?
Conversation
d80fe45
to
4c4c005
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #3045 +/- ##
==========================================
- Coverage 36.24% 36.08% -0.17%
==========================================
Files 428 434 +6
Lines 44860 45124 +264
==========================================
+ Hits 16261 16281 +20
- Misses 27425 27668 +243
- Partials 1174 1175 +1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -129,5 +133,51 @@ func CheckStart() error { | |||
} | |||
} | |||
|
|||
rocksDBMisspelling(ctx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can find a more common way to do the check, just like sanity check.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry to the
Unreleased
section inCHANGELOG.md
Reviewed
Files changed
in the github PR explorerFor Admin Use: