Skip to content

Commit

Permalink
set synchronizer sequential mode as default (0xPolygonHermez#2807)
Browse files Browse the repository at this point in the history
* set sequential mode as default
  • Loading branch information
joanestebanr authored Nov 20, 2023
1 parent e84aec6 commit 6d8cd1e
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion config/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func Test_Defaults(t *testing.T) {
},
{
path: "Synchronizer.L1SynchronizationMode",
expectedValue: "parallel",
expectedValue: "sequential",
},
{
path: "Synchronizer.L1ParallelSynchronization.MaxClients",
Expand Down
2 changes: 1 addition & 1 deletion config/default.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ EnableHttpLog = true
SyncInterval = "1s"
SyncChunkSize = 100
TrustedSequencerURL = "" # If it is empty or not specified, then the value is read from the smc
L1SynchronizationMode = "parallel"
L1SynchronizationMode = "sequential" # "sequential" or "parallel"
[Synchronizer.L1ParallelSynchronization]
MaxClients = 10
MaxPendingNoProcessedBlocks = 25
Expand Down
2 changes: 1 addition & 1 deletion docs/config-file/node-config-doc.html

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions docs/config-file/node-config-doc.md
Original file line number Diff line number Diff line change
Expand Up @@ -1240,16 +1240,16 @@ TrustedSequencerURL=""

**Type:** : `enum (of string)`

**Default:** `"parallel"`
**Default:** `"sequential"`

**Description:** L1SynchronizationMode define how to synchronize with L1:
- parallel: Request data to L1 in parallel, and process sequentially. The advantage is that executor is not blocked waiting for L1 data
- sequential: Request data to L1 and execute

**Example setting the default value** ("parallel"):
**Example setting the default value** ("sequential"):
```
[Synchronizer]
L1SynchronizationMode="parallel"
L1SynchronizationMode="sequential"
```

Must be one of:
Expand Down
2 changes: 1 addition & 1 deletion docs/config-file/node-config-schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@
"parallel"
],
"description": "L1SynchronizationMode define how to synchronize with L1:\n- parallel: Request data to L1 in parallel, and process sequentially. The advantage is that executor is not blocked waiting for L1 data\n- sequential: Request data to L1 and execute",
"default": "parallel"
"default": "sequential"
},
"L1ParallelSynchronization": {
"properties": {
Expand Down
2 changes: 1 addition & 1 deletion test/config/test.node.config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ EnableL2SuggestedGasPricePolling = true
SyncInterval = "1s"
SyncChunkSize = 100
TrustedSequencerURL = "" # If it is empty or not specified, then the value is read from the smc.
L1SynchronizationMode = "parallel"
L1SynchronizationMode = "sequential" # "sequential" or "parallel"
[Synchronizer.L1ParallelSynchronization]
MaxClients = 10
MaxPendingNoProcessedBlocks = 25
Expand Down

0 comments on commit 6d8cd1e

Please sign in to comment.