-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quarkus implementation of VileBot1 #161
Open
Christopher-Chianelli
wants to merge
79
commits into
oldterns:master
Choose a base branch
from
Christopher-Chianelli:quarkus-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Quarkus implementation of VileBot1 #161
Christopher-Chianelli
wants to merge
79
commits into
oldterns:master
from
Christopher-Chianelli:quarkus-refactor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Proper handling of lists
Rewrote to use Kitteh; now much faster to start |
UrlStreamHandler impl so mvn clean install works, formatting
@Kevin-Mok The Quarkus implementation VileBot1 is now (basically) 100% unit tested. Will do a few more final changes then undraft the PR. |
@Kevin-Mok Ready for review |
Here are the Lines of Code statistics that are relevant:
|
Is this backwards-compatible with the old Redis DB? |
@Kevin-Mok all redis database logic remained the same, so yes. |
- Make Client parameter get it from event - Fix VileBot1 default nick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite of VileBot to Quarkus. Currently a WIP; some nice features:
Better command syntax:
No need to add listeners to the main files.
Note:
Apache Camel seems slow to start; bootup with ping and (not fully working) karma system takes 40 seconds.