Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus implementation of VileBot1 #161

Open
wants to merge 79 commits into
base: master
Choose a base branch
from

Conversation

Christopher-Chianelli
Copy link
Contributor

This is a rewrite of VileBot to Quarkus. Currently a WIP; some nice features:

Better command syntax:

@OnChannelMessage("!mycommand @nick @amount")
public String myCommand(Nick nick, int amount, ChannelMessage message) {
    return message.getNick().getBaseNick() + " wants to transfer " + amount + " karma to " + nick.getBaseNick();
}

No need to add listeners to the main files.

Note:

Apache Camel seems slow to start; bootup with ping and (not fully working) karma system takes 40 seconds.

@Christopher-Chianelli
Copy link
Contributor Author

Rewrote to use Kitteh; now much faster to start

UrlStreamHandler impl so mvn clean install works, formatting
@Christopher-Chianelli
Copy link
Contributor Author

@Kevin-Mok The Quarkus implementation VileBot1 is now (basically) 100% unit tested. Will do a few more final changes then undraft the PR.

@Christopher-Chianelli Christopher-Chianelli marked this pull request as ready for review August 21, 2021 19:18
@Christopher-Chianelli
Copy link
Contributor Author

@Kevin-Mok Ready for review

@Christopher-Chianelli
Copy link
Contributor Author

Here are the Lines of Code statistics that are relevant:

Quarkus
src/main/java: 7874
src/test/java: 7498

quarkus-irc-bot (code that should never need to be touch): 1388 (includes tests, main code, deployment and runtime)
 

Old
src/main/java: 9815
src/test/java: 1408

@Kevin-Mok
Copy link

Is this backwards-compatible with the old Redis DB?

@Christopher-Chianelli
Copy link
Contributor Author

@Kevin-Mok all redis database logic remained the same, so yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants