Sanitize input files for !inspiration #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onyiny-ang
reviewed
Jul 10, 2018
| @@ -103,7 +103,7 @@ | |||
| 373 | |||
| 376 | |||
| 378 | |||
| 379:$100 invested at 7% interest for 100 years will become $100,000, at | |||
There was a problem hiding this comment.
What is actually causing the problem? Is it % anywhere, symbols generally or specifically %/symbol at the start of a sentence? Are the removals in this file just a precaution?
There was a problem hiding this comment.
This was more of a case of how that file was generated, It seems to have failed to parse out any lines with % in them. I cleaned that up while I was at it.
What caused the problem was the inspirations file using % as a line delimiter and a single line being %%
|
cough tests cough |
|
#52 is coming back from the dead. . .maybe :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR addresses a bug in the !inspiration command. Due to the way the input files are parsed, a certain pair of inspirations would be parsed as a single one:
!inspiration
When I'm ready to make a photograph, I think I quite obviously see in my minds
eye something that is not literally there in the true meaning of the word. I'm
interested in something which is built up from within, rather than just
extracted from without.
― Ansel Adams
%%
When in doubt, tell the truth.
― Mark Twain
This fix sanitizes both the inspirations and the inspiration index to address this issue.