-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dutch translations. #40
Added dutch translations. #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @iamreinder, this looks excellent; thank you for your contribution.
Would you consider becoming the code owner for the rules/nl
folder? Since I am not fluent in Dutch, it would be beneficial to have an expert like you overseeing that part.
@olebedev I made the requested change. In regards to being code owner, I think it makes sense. What do you expect of me as a code owner for the Dutch language rules? |
@iamreinder, not much, just to keep an eye on the incoming changes and verify if they still make sense for the Dutch language context. Does this sound good to you? |
Yeah, sure :-) |
Great! Can you then please add yourself into the |
Friendly ping @iamreinder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve it to get it in. I will add you @iamreinder into the contributors by myself later on.
Cheers,
Oleg
Hi there,
I came across this library and it was exactly what I needed for a task manager kind of tool. I needed Dutch translations, though. So I added rules for
nl
. Some parts might look a lot different from the English rules. That's because it's quite common to combine the day of the week with an indication of the part of the day in Dutch. For instance woensdagavond combines woensdag (wednesday) and avond (evening).All the tests pass. Let me know if you have any questions.
My kind regards,
Reinder.