Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dutch translations. #40

Merged
merged 6 commits into from
Nov 3, 2023

Conversation

iamreinder
Copy link
Collaborator

Hi there,

I came across this library and it was exactly what I needed for a task manager kind of tool. I needed Dutch translations, though. So I added rules for nl. Some parts might look a lot different from the English rules. That's because it's quite common to combine the day of the week with an indication of the part of the day in Dutch. For instance woensdagavond combines woensdag (wednesday) and avond (evening).

All the tests pass. Let me know if you have any questions.

My kind regards,
Reinder.

@iamreinder iamreinder requested a review from olebedev as a code owner September 6, 2023 14:34
olebedev
olebedev previously approved these changes Sep 17, 2023
Copy link
Owner

@olebedev olebedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @iamreinder, this looks excellent; thank you for your contribution.

Would you consider becoming the code owner for the rules/nl folder? Since I am not fluent in Dutch, it would be beneficial to have an expert like you overseeing that part.

when.go Outdated Show resolved Hide resolved
@iamreinder
Copy link
Collaborator Author

@olebedev I made the requested change. In regards to being code owner, I think it makes sense. What do you expect of me as a code owner for the Dutch language rules?

@olebedev
Copy link
Owner

olebedev commented Sep 23, 2023

What do you expect of me as a code owner for the Dutch language rules?

@iamreinder, not much, just to keep an eye on the incoming changes and verify if they still make sense for the Dutch language context. Does this sound good to you?

@iamreinder
Copy link
Collaborator Author

Yeah, sure :-)

@iamreinder iamreinder requested a review from olebedev September 25, 2023 08:48
@olebedev
Copy link
Owner

Great! Can you then please add yourself into the CODEOWNERS file? The change would be similar to this line but for the Dutch language.

@olebedev
Copy link
Owner

Friendly ping @iamreinder

Copy link
Owner

@olebedev olebedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve it to get it in. I will add you @iamreinder into the contributors by myself later on.

Cheers,
Oleg

@olebedev olebedev merged commit c72db38 into olebedev:master Nov 3, 2023
5 checks passed
@olebedev olebedev mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants