Add common Dutch expressions for day in last or next week, fixes #44 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olebedev
approved these changes
Dec 2, 2023
|
Hehe, I can imagine. I bet I would be in the same position when a feature like this was pull requested for the Chinese language 😅 Let's just say I implemented another way to describe a day in the past or future for the Dutch language. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented common Dutch expressions for a day in the last week, for example "vorige week woensdag" which translates to "last week on wednesday". Or a day in the next week, like "volgende week zondag" which translates to "next week on sunday." This is commonly used and is different from "next sunday." If I say today (on a friday) that I will see you "volgende week zondag" I mean the sunday after next sunday. Although it is less commonly used, I also added "komende week" which means the same as "volgende week."
This fixes the issue described in #44.