Merge pull request recogito#113 from oleksandr-danylchenko/recogito#112…

…-fix-transform-position-handling recogito#112 Fixed mispositioned `canvas` when `container` has `transform` applied
oleksandr-danylchenko · Jul 6, 2024 · fbe29fd · fbe29fd
2 parents 83cdbd0 + da9199a
commit fbe29fd
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/packages/text-annotator/src/highlight/canvas/canvasRenderer.ts b/packages/text-annotator/src/highlight/canvas/canvasRenderer.ts
@@ -37,7 +37,7 @@ const createRenderer = (container: HTMLElement): RendererImplementation => {
   const canvas = createCanvas();
   const ctx = canvas.getContext('2d');
 
-  container.insertBefore(canvas, container.firstChild);
+  document.body.appendChild(canvas);
 
   const redraw = (
     highlights: Highlight[],
@@ -127,7 +127,7 @@ const createRenderer = (container: HTMLElement): RendererImplementation => {
   }
 
   const destroy = () => {
-    container.removeChild(canvas);
+    canvas.remove();
 
     window.removeEventListener('resize', onResize);
   }

diff --git a/packages/text-annotator/src/presence/PresencePainter.ts b/packages/text-annotator/src/presence/PresencePainter.ts
@@ -1,8 +1,7 @@
 import type { Color, PresenceProvider, PresentUser } from '@annotorious/core';
 import type { AnnotationRects } from '../state';
-import type { HighlightStyle } from '../highlight/HighlightStyle';
-import type { HighlightPainter } from '../highlight/HighlightPainter';
-import type { PresencePainterOptions } from 'src/presence';
+import type { HighlightStyle, HighlightPainter } from '../highlight';
+import type { PresencePainterOptions } from '../presence';
 import type { ViewportBounds } from '../highlight/viewport';
 
 import './PresencePainter.css';
@@ -32,7 +31,7 @@ export const createPresencePainter = (
 
   const ctx = canvas.getContext('2d');
 
-  container.appendChild(canvas);
+  document.body.appendChild(canvas);
 
   const trackedAnnotations = new Map<string, PresentUser>();
 
@@ -117,4 +116,4 @@ export const createPresencePainter = (
     reset
   }
 
-}
+}
diff --git a/packages/text-annotator/test/annotations.w3c.json b/packages/text-annotator/test/annotations.w3c.json
@@ -143,4 +143,4 @@
       }
     ]
   }
-]
+]
-Original file line number
+Diff line change
@@ Expand Up / @@ -143,4 +143,4 @@ @@
           }
         ]
       }
-    ]
+    ]