fix(workspaces): workspace path constant cleared after first use #761
Conversation
|
Not sure if this is another Windows issue 🤷♂️ |
|
Really weird. I can confirm the same. Thanks for fixing either way. |
|
@olimorris fyi may be worth figuring out the "why" because it could be something that bites us somewhere else down the road too ;) I tried to figure out where it could be going wrong but cannot and it doesn't make sense! The only thing I can think of is something mutates it "by ref" accidentally somewhere else up/down stream 🤷♂️ It certainly wasn't obvious though where / how that could have been based on the time I spent trying to trace it (but did not spend too much time). |
Assuming lua works the same way as javascript, the path as a string should not mutate up/down stream so all I can think of is the parent constant object (table) |
|
I've put this on my "lower priority" list. Still a priority but I wanted to tweak my workspace file for the plugin and then use it for problems such as this. I think realistically, the constant manipulated has to be the answer. Wonder if setting path to a deep copy might fix this. |
Description
This is a weird one. I could not pinpoint the culprit, but if I started a chat convo, used /workspace slash command (works fine the first time), but then create a new convo and try /workspace slash again it gives a plenary error (see screenshot below).
The path arg going into the function is blank and somehow the CONSTANT for the path in that file is also suddenly blank.
You can see what I mean by the change in my commit (a couple lines). This solves my immediate problem but I have no clue if there is something more / deeper that has to be addressed 🤷♂️
Related Issue(s)
No idea but curious if this is somehow related to #756 ?
Screenshots
Checklist