🐛 Destination snowflake: fix check (airbytehq#34528)

ollionorg · Feb 26, 2024 · ae1c007 · ae1c007
1 parent 749bcde
commit ae1c007
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/airbyte-integrations/connectors/destination-snowflake/metadata.yaml b/airbyte-integrations/connectors/destination-snowflake/metadata.yaml
@@ -5,7 +5,7 @@ data:
   connectorSubtype: database
   connectorType: destination
   definitionId: 424892c4-daac-4491-b35d-c6688ba547ba
-  dockerImageTag: 3.5.2
+  dockerImageTag: 3.5.3
   dockerRepository: airbyte/destination-snowflake
   documentationUrl: https://docs.airbyte.com/integrations/destinations/snowflake
   githubIssueLabel: destination-snowflake
@@ -14,12 +14,8 @@ data:
   name: Snowflake
   registries:
     cloud:
-      # 3.5.2 is broken; pinning back to the last known-good version
-      dockerImageTag: 3.4.22
       enabled: true
     oss:
-      # 3.5.2 is broken; pinning back to the last known-good version
-      dockerImageTag: 3.4.22
       enabled: true
   releaseStage: generally_available
   releases:

diff --git a/...e/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeSqlOperations.java b/...e/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeSqlOperations.java
@@ -109,8 +109,9 @@ public void insertRecordsInternal(final JdbcDatabase database,
   @Override
   protected void insertRecordsInternalV2(final JdbcDatabase jdbcDatabase, final List<PartialAirbyteMessage> list, final String s, final String s1)
       throws Exception {
-    // Snowflake doesn't have standard inserts... so we probably never want to do this
-    throw new UnsupportedOperationException("Snowflake does not use the native JDBC DV2 interface");
+    // Snowflake doesn't have standard inserts... so we don't do this at real runtime.
+    // Intentionally do nothing. This method is called from the `check` method.
+    // It probably shouldn't be, but this is the easiest path to getting this working.
   }
 
   protected String generateFilesList(final List<String> files) {

diff --git a/docs/integrations/destinations/snowflake.md b/docs/integrations/destinations/snowflake.md
@@ -246,6 +246,7 @@ Otherwise, make sure to grant the role the required permissions in the desired n
 
 | Version         | Date       | Pull Request                                               | Subject                                                                                                                                                         |
 |:----------------|:-----------|:-----------------------------------------------------------|:----------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| 3.5.3           | 2024-01-25 | [\#34528](https://github.com/airbytehq/airbyte/pull/34528) | Fix spurious `check` failure (`UnsupportedOperationException: Snowflake does not use the native JDBC DV2 interface`)                                            |
 | 3.5.2           | 2024-01-24 | [\#34458](https://github.com/airbytehq/airbyte/pull/34458) | Improve error reporting                                                                                                                                         |
 | 3.5.1           | 2024-01-24 | [\#34501](https://github.com/airbytehq/airbyte/pull/34501) | Internal code changes for Destinations V2                                                                                                                       |
 | 3.5.0           | 2024-01-24 | [\#34462](https://github.com/airbytehq/airbyte/pull/34462) | Upgrade CDK to 0.14.0                                                                                                                                           |