Skip to content
This repository has been archived by the owner on Aug 23, 2021. It is now read-only.

Auctionmark on MyRocks #246

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

samehdi
Copy link
Contributor

@samehdi samehdi commented Apr 18, 2018

Config file and ddl file for running the Auctionmark benchmark on MyRocks. Differences include:

  1. Setting the transaction isolation level to REPEATABLE_READ since that is the highest level MyRocks supports.

  2. In the ddl file, commenting out Foreign Key constraints since MyRocks does not support them

  3. Adding the following index
    CREATE INDEX IDX_ITEM_BID ON ITEM_BID (ib_i_id, ib_u_id);
    The reason is that when the foreign key constraints are removed above, implicit secondary indexes for those constraints are also not created (https://dev.mysql.com/doc/refman/5.6/en/create-table-foreign-keys.html). The above index is required for performance otherwise getMaxBidId query in NewBid.java takes orders of magnitude more time with reasonably large scale factors and kills performance.

samehdi and others added 3 commits April 18, 2018 15:43
… schema in a previous

commit (since MyRocks does not support them), killed throughput of auctionmark on MyRocks.
Foreign key constraints implicitly add secondary indexes
(https://dev.mysql.com/doc/refman/5.6/en/create-table-foreign-keys.html)
One of these indexes was required to make the getMaxBidId query in NewBid.java perform well, so
explicitly added that index.
@apavlo
Copy link
Member

apavlo commented Apr 19, 2018

This looks reasonable to me. I will merge when the build passes.

@samehdi
Copy link
Contributor Author

samehdi commented Apr 21, 2018

Thanks. Although I am thinking that explicit indexes should be added for all other foreign key constraints that were commented out as well. That would provide a more accurate comparison with other databases (e.g. mysql-innodb) that currently support foreign keys and will therefore pay the overhead of maintaining those implicit indexes on this benchmark.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants