Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing yaml method dump_all #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add missing yaml method dump_all #65

wants to merge 1 commit into from

Conversation

guerremdq
Copy link
Contributor

No description provided.

@mb-m mb-m self-requested a review January 23, 2019 09:56
@mb-m
Copy link
Contributor

mb-m commented Jan 23, 2019

Seems reasonable - I assume you've tested this? Can you show it works with something expandable (eg. Confidential) before merging?

mb-m
mb-m approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@mb-m mb-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable as per my comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mb-m mb-m mb-m approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guerremdq @mb-m