Skip to content

Commit

Permalink
Set shared memory size to 256m to support memory intensive content re…
Browse files Browse the repository at this point in the history
…ndering.
  • Loading branch information
omartrigui committed Jun 23, 2020
1 parent f58c63a commit 71eaad6
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ docker.run:
-e URL=https://www.youtube.com/watch?v=PBYKqvDK8d8 \
-e DURATION=20 \
-e OUTPUT_FILENAME=forever_tracey.mp4 \
--shm-size=256m \
"${IMAGE}"

.PHONY: docker.push
Expand Down
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ docker run --rm \
-e URL=https://www.youtube.com/watch?v=PBYKqvDK8d8 \
-e DURATION=20 \
-e OUTPUT_FILENAME=forever_tracey.mp4 \
--shm-size=256m \
cipheredbytes/url-to-video
```
This is a [sample](./samples/forever_tracey.mp4) output file.
Expand All @@ -37,10 +38,10 @@ git https://github.com/OmarTrigui/url-to-video.git && cd url-to-video/
make docker.build docker.run
```

## Todo list
## Roadmap

- [ ] Add E2E tests
- [ ] Tweak recording performance
- [ ] Tune recording performance (reduce resource consumption)
- [ ] Add Pub/Sub support (either [SQS](https://aws.amazon.com/sqs/) or [Kafka](https://kafka.apache.org/))


Expand Down
2 changes: 2 additions & 0 deletions main.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ var opts = {
tcpTimeout: 100
}

// List of Chromium Command Line Switches
// https://peter.sh/experiments/chromium-command-line-switches/
function getStartChromeCommand () {
return 'DISPLAY=:1.0 /bin/sh -c ' +
'"/opt/google/chrome/google-chrome ' +
Expand Down

0 comments on commit 71eaad6

Please sign in to comment.