Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: omit empty fields like 'private_network' which have an empty valu… #32

Merged
merged 2 commits into from
May 15, 2024

Conversation

momer
Copy link
Collaborator

@momer momer commented May 15, 2024

…e which can mislead users. Update VCR tests

@momer momer force-pushed the dx/omit-empty-values-for-cluster branch from e64d765 to 28eac6b Compare May 15, 2024 01:13
@momer momer force-pushed the dx/omit-empty-values-for-cluster branch from 28eac6b to 285872e Compare May 15, 2024 01:19
@momer momer marked this pull request as ready for review May 15, 2024 01:25
@momer
Copy link
Collaborator Author

momer commented May 15, 2024

Many lines of VCR recordings, few of .go; not the prettiest PR, but we're unreleased - so preferring to push these changes at once rather than breaking apart.

@momer momer merged commit 74e7476 into main May 15, 2024
4 checks passed
@momer momer deleted the dx/omit-empty-values-for-cluster branch May 15, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant